From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56EE321DFA8F2 for ; Thu, 6 Apr 2017 10:17:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70C3080082; Thu, 6 Apr 2017 17:17:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 70C3080082 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 70C3080082 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88CF7E218; Thu, 6 Apr 2017 17:17:23 +0000 (UTC) To: "Long, Qin" , "edk2-devel@lists.01.org" References: <20170401053834.12856-1-qin.long@intel.com> <51a65891-7565-086a-3827-f29d6b0d3529@redhat.com> <9304ab09-441f-0794-d2da-6cefa7f97672@redhat.com> Cc: "Ye, Ting" , "Wu, Hao A" , "Tian, Feng" , "Dong, Eric" From: Laszlo Ersek Message-ID: Date: Thu, 6 Apr 2017 19:17:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 06 Apr 2017 17:17:25 +0000 (UTC) Subject: Re: [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 17:17:26 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/06/17 16:17, Long, Qin wrote: >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Thursday, April 6, 2017 8:57 PM >> To: Long, Qin ; edk2-devel@lists.01.org >> Cc: Ye, Ting ; Wu, Hao A ; Tian, >> Feng ; Dong, Eric >> Subject: Re: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues >> >> On 04/06/17 13:26, Long, Qin wrote: >>> Thanks, Laszlo. >>> >>> And the last "workaround" patch can be dropped, since we introduced >>> the new [Includes.Common.Private] setting in Package DEC file (from my >>> last patch). This will help to eliminate the potential macro >>> re-definition risk. >> >> Is the [Includes.Common.Private] section documented somewhere? I >> checked the DEC spec v1.25, and it's not described there. Should I file a >> documentation BZ about this? > > The feature was introduced by the Commit ("c28d2e1047816164ffec552e4a3375122cbcc6b6"). Oh, this looks very useful. Thanks! Laszlo > I will check the documentation status with the owner. > >> >> Thanks >> Laszlo >> >>> It's still valuable to refine openssl e_os2.h definition for >>> consistence, which was submitted / approved by the PR >>> (https://github.com/openssl/openssl/pull/3121) >>> >>> >>> Best Regards & Thanks, >>> LONG, Qin >>> >>>> -----Original Message----- >>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf >>>> Of Laszlo Ersek >>>> Sent: Thursday, April 6, 2017 4:55 PM >>>> To: Long, Qin ; edk2-devel@lists.01.org >>>> Cc: Ye, Ting ; Wu, Hao A ; >>>> Tian, Feng ; Dong, Eric >>>> Subject: Re: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build >>>> Issues >>>> >>>> On 04/01/17 07:38, Long Qin wrote: >>>>> From: Qin Long >>>>> >>>>> V2: >>>>> Updated the patches as the comments from Laszlo >> (lersek@redhat.com). >>>>> And filed two TianoCore BZ (#455, #456) to track the further follow-ups >>>>> on openssl and EDKII-CryptoPkg: >>>>> https://bugzilla.tianocore.org/show_bug.cgi?id=455 >>>>> https://bugzilla.tianocore.org/show_bug.cgi?id=456 >>>>> >>>>> This patch series introduced some hotfixes and workaround to resolve >>>>> the build issues under different toolchain, and from potential >>>>> external consumers, including: >>>>> - build warning under GCC48 and VS2010 toolchain; >>>>> - Potential unresolved external symbol link issue; >>>>> - One bug fix of timer() wrapper in ConstantTimeClock.c; >>>>> - One workaround to resolve macro re-definitions issue from some >>>>> external BaseCryptLib consumer. >>>>> >>>>> (https://github.com/qloong/edk2/commits/dev-openssl-hotfix) >>>>> >>>>> Qin Long (4): >>>>> CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source >>>>> CryptoPkg: Fix possible unresolved external symbol issue. >>>>> CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper. >>>>> CryptoPkg: One workaround to resolve potential build issue. >>>>> >>>>> CryptoPkg/Include/CrtLibSupport.h | 1 + >>>>> CryptoPkg/Include/openssl/e_os2.h | 321 >>>> +++++++++++++++++++++ >>>>> .../BaseCryptLib/SysCall/ConstantTimeClock.c | 6 +- >>>>> CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 +- >>>>> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 15 +- >>>>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 15 +- >>>>> 6 files changed, 355 insertions(+), 13 deletions(-) create mode >>>>> 100644 CryptoPkg/Include/openssl/e_os2.h >>>>> >>>> >>>> I can see the upstream OpenSSL pull req / issue report references in >>>> TianoCore BZs 455 and 456. >>>> >>>> series >>>> Reviewed-by: Laszlo Ersek >>>> >>>> Thanks! >>>> Laszlo >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >