Re: [edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

["Stefan Berger" <stefanb@linux.ibm.com>]

On 9/18/21 4:48 AM, Sami Mujawar wrote:
> Hi Stefan,
>
> Thank you for this patch.
>
> I have a few minor comments marked inline as [SAMI].
>
> Regards,
>
> Sami Mujawar
>
>
> On 16/09/2021 10:17 PM, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.vnet.ibm.com>
>>
>> Add a NULL implementation of the library class TpmPlatformHierarchyLib.
> [SAMI] Is it possible to add a link to the bugzilla
> (https://bugzilla.tianocore.org/show_bug.cgi?id=3510), please?
> Also, would it be possible to place 'PeiDxeTpmPlatformHierarchyLibNull'
> in SecurityPkg (i.e. if this library can be useful for other
> architectures).


Yes. I didn't put it there because it was 'specialized' for ARM, but I 
don't mind moving it there on next round.


>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>> ---
>>   ArmVirtPkg/ArmVirtPkg.dec                     |  1 +
>>   .../Include/Library/TpmPlatformHierarchyLib.h | 27 +++++++++++++++++
>>   .../PeiDxeTpmPlatformHierarchyLib.c           | 22 ++++++++++++++
>>   .../PeiDxeTpmPlatformHierarchyLib.inf         | 30 +++++++++++++++++++
>>   4 files changed, 80 insertions(+)
>>   create mode 100644 
>> ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h
>>   create mode 100644 
>> ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c
>>   create mode 100644 
>> ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
>>
>> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec
>> index 4e4d758015..f3bdca118b 100644
>> --- a/ArmVirtPkg/ArmVirtPkg.dec
>> +++ b/ArmVirtPkg/ArmVirtPkg.dec
>> @@ -27,6 +27,7 @@
>>
>>
>>   [LibraryClasses]
>>
>>     ArmVirtMemInfoLib|Include/Library/ArmVirtMemInfoLib.h
>>
>> + TpmPlatformHierarchyLib|Include/Library/TpmPlatformHierarchyLib.h
> [SAMI] The file 'ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h'
> appears to be a copy of the header file
> SecurityPkg/Include/Library/TpmPlatformHierarchyLib.h. Is this needed
> here or we could reference the one from SecurityPkg?

I added it since one of the test builds complaint about a missing header 
file. This silenced it. If we move the NULL implementation to 
SecruityPkg, then we won't need this anymore.