From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web09.5165.1631966272760314362 for ; Sat, 18 Sep 2021 04:57:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=pu2ZTT3H; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18I7T63N030006; Sat, 18 Sep 2021 07:57:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=IC6xe8U02i4jUNXAWTR0BZfKZ4Phq0ZQyj/arW+n0Yk=; b=pu2ZTT3HBdR8dKluigV3ycA86+gG/a9EpIZ0svMnTnC7UT+Vdl0mvPZOnO10JQ1mX3Og jo1nVu9rkZc16brP7cREcoQWyoty2OWuqSuuw2Gc+HupippcFLvJ0m3auVubJrDUJmgJ OudOoeJ7EWS/MxB0Fe24YAIEp9C+hMlVHrBo3r1PQWU7YMCm8haeueZaxqVULAqhv/3b xN0JSZEr5QBX1JNFFOmlDLZuf/BD0UpXrkGJUbEfKOpbxrxbULj/kbNuQ3pmv1k/Kf1R d6O3BO2h4sNukgGjdLasHJMd7L2KV2X7t+knNf0SCURvmSoAOGmNkGmhSsHbD6dxLA5g bQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5brvu10p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 07:57:48 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18IBtiPt028882; Sat, 18 Sep 2021 07:57:48 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5brvu10f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 07:57:48 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18IBvF4U005364; Sat, 18 Sep 2021 11:57:47 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma03dal.us.ibm.com with ESMTP id 3b57r8wgsq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 11:57:47 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18IBvkup41287938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Sep 2021 11:57:46 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5ADED112063; Sat, 18 Sep 2021 11:57:46 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39DC3112062; Sat, 18 Sep 2021 11:57:46 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Sat, 18 Sep 2021 11:57:46 +0000 (GMT) Subject: Re: [edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: marcandre.lureau@redhat.com, kraxel@redhat.com, jiewen.yao@intel.com, ardb+tianocore@kernel.org, leif@nuviainc.com, Stefan Berger References: <20210916211752.2714332-1-stefanb@linux.ibm.com> <20210916211752.2714332-2-stefanb@linux.ibm.com> From: "Stefan Berger" Message-ID: Date: Sat, 18 Sep 2021 07:57:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZiJdtOE_Ohckw6suNtR3h6MyZaeoO-0u X-Proofpoint-GUID: sjzpJdGBJ5IuXRf3HLBUZLCqQ9PP5DCT X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-18_03,2021-09-17_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109180080 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 18I7T63N030006 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/18/21 4:48 AM, Sami Mujawar wrote: > Hi Stefan, > > Thank you for this patch. > > I have a few minor comments marked inline as [SAMI]. > > Regards, > > Sami Mujawar > > > On 16/09/2021 10:17 PM, Stefan Berger wrote: >> From: Stefan Berger >> >> Add a NULL implementation of the library class TpmPlatformHierarchyLib. > [SAMI] Is it possible to add a link to the bugzilla > (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3510), please? > Also, would it be possible to place 'PeiDxeTpmPlatformHierarchyLibNull' > in SecurityPkg (i.e. if this library can be useful for other > architectures). Yes. I didn't put it there because it was 'specialized' for ARM, but I=20 don't mind moving it there on next round. >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Sami Mujawar >> Cc: Gerd Hoffmann >> Signed-off-by: Stefan Berger >> --- >> =C2=A0 ArmVirtPkg/ArmVirtPkg.dec=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 1 + >> =C2=A0 .../Include/Library/TpmPlatformHierarchyLib.h | 27 ++++++++++++= +++++ >> =C2=A0 .../PeiDxeTpmPlatformHierarchyLib.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 22 ++++++++++++++ >> =C2=A0 .../PeiDxeTpmPlatformHierarchyLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 30 +++++++++++++++++++ >> =C2=A0 4 files changed, 80 insertions(+) >> =C2=A0 create mode 100644=20 >> ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h >> =C2=A0 create mode 100644=20 >> ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatform= HierarchyLib.c >> =C2=A0 create mode 100644=20 >> ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatform= HierarchyLib.inf >> >> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec >> index 4e4d758015..f3bdca118b 100644 >> --- a/ArmVirtPkg/ArmVirtPkg.dec >> +++ b/ArmVirtPkg/ArmVirtPkg.dec >> @@ -27,6 +27,7 @@ >> >> >> =C2=A0 [LibraryClasses] >> >> =C2=A0=C2=A0=C2=A0 ArmVirtMemInfoLib|Include/Library/ArmVirtMemInfoLib= .h >> >> + TpmPlatformHierarchyLib|Include/Library/TpmPlatformHierarchyLib.h > [SAMI] The file 'ArmVirtPkg/Include/Library/TpmPlatformHierarchyLib.h' > appears to be a copy of the header file > SecurityPkg/Include/Library/TpmPlatformHierarchyLib.h. Is this needed > here or we could reference the one from SecurityPkg? I added it since one of the test builds complaint about a missing header=20 file. This silenced it. If we move the NULL implementation to=20 SecruityPkg, then we won't need this anymore.