From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 09 May 2019 14:26:43 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65AF8356D3; Thu, 9 May 2019 21:26:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-234.rdu2.redhat.com [10.10.120.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1360E60CCD; Thu, 9 May 2019 21:26:40 +0000 (UTC) Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value. To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Dong, Eric" Cc: "Wu, Hao A" References: <20190508030150.3968-1-eric.dong@intel.com> <20190508030150.3968-2-eric.dong@intel.com> <8661d7f6-57f6-1a27-b64d-4286f2db12a7@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503F637450@shsmsx102.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 9 May 2019 23:26:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F637450@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 09 May 2019 21:26:42 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Jiewen, On 05/09/19 14:41, Yao, Jiewen wrote: > Hey > When I read https://bugzilla.tianocore.org/show_bug.cgi?id=1782, it says: "Current opal driver send blockSid command at ReadyToBoot event, it should been update to EndOfDxe point. Submit this bz to update the code." > > But this patch is to update the default value. > > I am very confused. > > May I know what is the relationship between this patch and Bugzilla? > Why we need change the default value? I have absolutely no clue -- I only commented because I prefer a patch subject to state *specifically* what a patch does. "Change default value" was too vague. (When I commented I hadn't seen Hao Wu's similar feedback just yet.) Now, *why* this change is necessary, is totally over my head; I didn't even begin to think about that. Thanks Laszlo > > > Thank you > Yao Jiewen > > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, May 9, 2019 2:53 AM >> To: devel@edk2.groups.io; Dong, Eric >> Cc: Wu, Hao A >> Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: >> Change default value. >> >> On 05/08/19 05:01, Dong, Eric wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=1782 >>> >>> Change BlockSID default policy, default enable BlockSid. >>> >>> Signed-off-by: Eric Dong >>> Cc: Hao Wu >>> --- >>> SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++- >>> SecurityPkg/SecurityPkg.dec | 2 +- >>> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> Please change the subject line as follows: >> >> ---- >> SecurityPkg: enable BlockSID in PcdTcg2PhysicalPresenceFlags DEC default >> ---- >> >> no need to resubmit just for this, just pls update the patch before you >> push it. >> >> Thanks >> Laszlo >> >>> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >>> index d9eee7f3e8..8da3deaf86 100644 >>> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >>> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h >>> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >>> // Default value >>> // >>> #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT >> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE >> _BLOCK_SID | \ >>> - >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_ >> BLOCK_SID) >>> + >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_ >> BLOCK_SID |\ >>> + >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID) >>> >>> /** >>> Check and execute the pending TPM request. >>> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec >>> index 6e4c4c3a02..3314f1854b 100644 >>> --- a/SecurityPkg/SecurityPkg.dec >>> +++ b/SecurityPkg/SecurityPkg.dec >>> @@ -410,7 +410,7 @@ >>> # PCD can be configured for different settings in different scenarios >>> # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT >> | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT >>> # @Prompt Initial setting of TCG2 Persistent Firmware Management >> Flags >>> - >> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI >> NT32|0x0001001B >>> + >> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UI >> NT32|0x0001001B >>> >>> ## Indicate current TPM2 Interrupt Number reported by _CRS control >> method.

>>> # TPM2 Interrupt feature is disabled If the pcd is set to 0.
>>> >> >> >> >