Re: 回复: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

["PierreGondois" <pierre.gondois@arm.com>]

Hello Liming, Jiewen,


On 7/10/23 03:26, gaoliming wrote:
> Pierre:
>    Another option is to define two PCD for Rng algorithm in MdePkg. One PCD value is ArmRndr GUID, another is UnSafe GUID. This way can also resolve the package dependency.

So there would be a Pcd for the unsafe algorithm so that the platform can
choose a custom GUID to advertise the unsafe algorithm ? If so, I think
it would be better to have only one common GUID,

> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
>> 发送时间: 2023年7月7日 22:34
>> 收件人: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Pierre
>> Gondois <pierre.gondois@arm.com>
>> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Wang,
>> Jian J <jian.j.wang@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
>> Sami Mujawar <sami.mujawar@arm.com>; Jose Marinho
>> <Jose.Marinho@arm.com>; Kun Qin <kuqin12@gmail.com>
>> 主题: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe
>> Rng algorithms
>>
>> I think a better way is to define a new library instance in other package with
>> the new ARM APIs.
>> The old one can be kept as is.
>>
>> That will limit the impact to existing platform.

Yes right,
However this would mean having 2 identical implementations of the BaseRngTimerLib,
I ll try to move the library instead, if it's ok

Regards,
Pierre

>>
>>
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
>> Jiewen
>>> Sent: Friday, July 7, 2023 10:28 PM
>>> To: Pierre Gondois <pierre.gondois@arm.com>; devel@edk2.groups.io
>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>>> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
>> Wang,
>>> Jian J <jian.j.wang@intel.com>; Ard Biesheuvel
>> <ardb+tianocore@kernel.org>;
>>> Sami Mujawar <sami.mujawar@arm.com>; Jose Marinho
>>> <Jose.Marinho@arm.com>; Kun Qin <kuqin12@gmail.com>
>>> Subject: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to
>> describe
>>> Rng algorithms
>>>
>>> Thanks Pierre.
>>> Yes, I agree to move it to other package to resolve dependency issue.
>>>
>>>> -----Original Message-----
>>>> From: Pierre Gondois <pierre.gondois@arm.com>
>>>> Sent: Friday, July 7, 2023 10:25 PM
>>>> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>>>> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
>> Wang,
>>>> Jian J <jian.j.wang@intel.com>; Ard Biesheuvel
>> <ardb+tianocore@kernel.org>;
>>>> Sami Mujawar <sami.mujawar@arm.com>; Jose Marinho
>>>> <Jose.Marinho@arm.com>; Kun Qin <kuqin12@gmail.com>
>>>> Subject: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to
>> describe
>>>> Rng algorithms
>>>>
>>>> Hello Jiewen,
>>>>
>>>> We have the following dependency issue:
>>>> - the BaseRngTimerLib is in the MdePkg
>>>> - we need a GUID to describe the BaseRngTimerLib algorithm
>>>> - we cannot add the gEdkiiRngAlgorithmUnSafe in the MdePkg, and the
>>>> gZeroGuid is also not in the MdePkg
>>>> - the MdePkg should not have dependencies over other packages
>>>>
>>>> As the BaseRngTimerLib is not really standard and should not be used in
>>>> production builds,
>>>> would you agree if it was moved to the MdeModulePkg or to the
>> SecurityPkg
>>>> (with the gEdkiiRngAlgorithmUnSafe definition) ?
>>>>
>>>> Regards,
>>>> Pierre
>>>>