From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6306.1689078224666893316 for ; Tue, 11 Jul 2023 05:23:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18E2B1FB; Tue, 11 Jul 2023 05:24:26 -0700 (PDT) Received: from [192.168.1.12] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4B573F67D; Tue, 11 Jul 2023 05:23:41 -0700 (PDT) Message-ID: Date: Tue, 11 Jul 2023 14:23:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 From: "PierreGondois" Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAzLzZdIE1kZVBrZy9Sbmc6IEFkZCBHVUlEcyB0byBkZXNjcmliZSBSbmcgYWxnb3JpdGhtcw==?= To: gaoliming , devel@edk2.groups.io, jiewen.yao@intel.com Cc: "'Kinney, Michael D'" , "'Liu, Zhiguang'" , "'Wang, Jian J'" , 'Ard Biesheuvel' , 'Sami Mujawar' , 'Jose Marinho' , 'Kun Qin' References: <20230706085159.626374-1-pierre.gondois@arm.com> <20230706085159.626374-4-pierre.gondois@arm.com> <08f90a96-e053-cb5d-abeb-cb63b85f14cc@arm.com> <176F972B57840483.2683@groups.io> <03d09427-a2da-4ab8-ed9e-0955158b2b9b@arm.com> <176F9C2F554052EE.2683@groups.io> <007f01d9b2cd$8aa15910$9fe40b30$@byosoft.com.cn> In-Reply-To: <007f01d9b2cd$8aa15910$9fe40b30$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hello Liming, Jiewen, On 7/10/23 03:26, gaoliming wrote: > Pierre: > Another option is to define two PCD for Rng algorithm in MdePkg. One= PCD value is ArmRndr GUID, another is UnSafe GUID. This way can also res= olve the package dependency. So there would be a Pcd for the unsafe algorithm so that the platform can choose a custom GUID to advertise the unsafe algorithm ? If so, I think it would be better to have only one common GUID, >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Yao, Jiewen >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B47=E6=9C=887=E6=97=A5= 22:34 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Yao, Jiewen ; Pierre >> Gondois >> =E6=8A=84=E9=80=81: Kinney, Michael D ; Ga= o, Liming >> ; Liu, Zhiguang ; Wa= ng, >> Jian J ; Ard Biesheuvel ; >> Sami Mujawar ; Jose Marinho >> ; Kun Qin >> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GU= IDs to describe >> Rng algorithms >> >> I think a better way is to define a new library instance in other pack= age with >> the new ARM APIs. >> The old one can be kept as is. >> >> That will limit the impact to existing platform. Yes right, However this would mean having 2 identical implementations of the BaseRng= TimerLib, I ll try to move the library instead, if it's ok Regards, Pierre >> >> >> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of Yao, >> Jiewen >>> Sent: Friday, July 7, 2023 10:28 PM >>> To: Pierre Gondois ; devel@edk2.groups.io >>> Cc: Kinney, Michael D ; Gao, Liming >>> ; Liu, Zhiguang ; >> Wang, >>> Jian J ; Ard Biesheuvel >> ; >>> Sami Mujawar ; Jose Marinho >>> ; Kun Qin >>> Subject: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to >> describe >>> Rng algorithms >>> >>> Thanks Pierre. >>> Yes, I agree to move it to other package to resolve dependency issue. >>> >>>> -----Original Message----- >>>> From: Pierre Gondois >>>> Sent: Friday, July 7, 2023 10:25 PM >>>> To: Yao, Jiewen ; devel@edk2.groups.io >>>> Cc: Kinney, Michael D ; Gao, Liming >>>> ; Liu, Zhiguang ; >> Wang, >>>> Jian J ; Ard Biesheuvel >> ; >>>> Sami Mujawar ; Jose Marinho >>>> ; Kun Qin >>>> Subject: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to >> describe >>>> Rng algorithms >>>> >>>> Hello Jiewen, >>>> >>>> We have the following dependency issue: >>>> - the BaseRngTimerLib is in the MdePkg >>>> - we need a GUID to describe the BaseRngTimerLib algorithm >>>> - we cannot add the gEdkiiRngAlgorithmUnSafe in the MdePkg, and the >>>> gZeroGuid is also not in the MdePkg >>>> - the MdePkg should not have dependencies over other packages >>>> >>>> As the BaseRngTimerLib is not really standard and should not be used= in >>>> production builds, >>>> would you agree if it was moved to the MdeModulePkg or to the >> SecurityPkg >>>> (with the gEdkiiRngAlgorithmUnSafe definition) ? >>>> >>>> Regards, >>>> Pierre >>>>