From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Michael Roth <michael.roth@amd.com>
Cc: devel@edk2.groups.io, YuanhaoXie <yuanhao.xie@intel.com>,
Tom Lendacky <Thomas.Lendacky@amd.com>,
Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Min Xu <min.m.xu@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti
Date: Mon, 21 Aug 2023 16:34:43 +0200 [thread overview]
Message-ID: <cfdtlvlsdytvyyckalgz7wu7ska6zn576rfz5nklb6csugb7ys@kgp3junkvylj> (raw)
In-Reply-To: <20230816201146.1634348-3-michael.roth@amd.com>
On Wed, Aug 16, 2023 at 03:11:46PM -0500, Michael Roth wrote:
> PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when
> the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is
> true by default, but needs to be disabled for QEMU/OVMF where early INIT
> is not simulated. Commit 1d76560146 ("OvmfPkg: Disable
> PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it
> by default for OvmfPkg, but a similar change was not made for the
> AmdSev package. This breaks booting of SEV and SNP guests.
>
> Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev
> package, as was previously done for OvmfPkg variants.
I suspect all ovmf builds need that, including AmdSev, IntelTdx,
Microvm variants. Xen probably too. Not sure about Bhyve.
So, a step into the right direction but not complete ...
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107918): https://edk2.groups.io/g/devel/message/107918
Mute This Topic: https://groups.io/mt/100787520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-08-21 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 20:11 [edk2-devel] [0/2] Fixes for AmdSev OVMF package regressions Roth, Michael via groups.io
2023-08-16 20:11 ` [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot Roth, Michael via groups.io
2023-08-21 14:29 ` Gerd Hoffmann
2023-08-21 14:53 ` Yao, Jiewen
2023-08-16 20:11 ` [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti Roth, Michael via groups.io
2023-08-16 20:22 ` Ard Biesheuvel
2023-09-05 13:33 ` Gerd Hoffmann
2023-08-21 14:34 ` Gerd Hoffmann [this message]
2023-08-22 6:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfdtlvlsdytvyyckalgz7wu7ska6zn576rfz5nklb6csugb7ys@kgp3junkvylj \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox