From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 4A4BD1A1E20
 for <edk2-devel@ml01.01.org>; Fri, 29 Jul 2016 00:42:57 -0700 (PDT)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id C78DE12B7;
 Fri, 29 Jul 2016 07:42:56 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-38.phx2.redhat.com
 [10.3.116.38])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u6T7gshK029511; Fri, 29 Jul 2016 03:42:55 -0400
To: Gary Lin <glin@suse.com>, edk2-devel@ml01.01.org
References: <20160729032538.17730-1-glin@suse.com>
 <20160729032538.17730-3-glin@suse.com>
Cc: David Wei <david.wei@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <cfe1c236-906c-360f-c341-a24991507bfc@redhat.com>
Date: Fri, 29 Jul 2016 09:42:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160729032538.17730-3-glin@suse.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Fri, 29 Jul 2016 07:42:56 +0000 (UTC)
Subject: Re: [PATCH v2 02/19] Vlv2TbltDevicePkg: Only define MDEPKG_NDEBUG for gcc release build
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2016 07:42:57 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 07/29/16 05:25, Gary Lin wrote:
> We only enable "-Wno-unused-but-set-variable" for the release build
> and gcc would complain that the varible passed to ASSERT_EFI_ERROR
> wasn't used in the debug build. Just don't define MDEPKG_NDEBUG for
> the debug build to make gcc happy with ASSERT_EFI_ERROR.
> 
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Cc: David Wei <david.wei@intel.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index a3f4c9a..e57d2ad 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -1117,7 +1117,7 @@ [Components.X64]
>      !endif
>         <BuildOptions>
>          ICC:*_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
> -        GCC:*_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
> +        GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
>    }
>    MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
>      <LibraryClasses>
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>