* [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
@ 2020-10-02 11:44 Maciej Rabeda
2020-10-09 8:41 ` Siyuan, Fu
0 siblings, 1 reply; 3+ messages in thread
From: Maciej Rabeda @ 2020-10-02 11:44 UTC (permalink / raw)
To: devel; +Cc: Jiaxin Wu, Siyuan Fu
Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
causes NetworkPkg build to fail due to lack of RngLib entry in
NetworkPkg's .dsc file.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
---
NetworkPkg/NetworkPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index 503d828f91e6..716d04fdadb2 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++ b/NetworkPkg/NetworkPkg.dsc
@@ -40,6 +40,7 @@
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+ RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
!ifdef CONTINUOUS_INTEGRATION
BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
--
2.24.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
2020-10-02 11:44 [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file Maciej Rabeda
@ 2020-10-09 8:41 ` Siyuan, Fu
2020-10-09 9:13 ` [edk2-devel] " Maciej Rabeda
0 siblings, 1 reply; 3+ messages in thread
From: Siyuan, Fu @ 2020-10-09 8:41 UTC (permalink / raw)
To: Maciej Rabeda, devel@edk2.groups.io; +Cc: Wu, Jiaxin
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
> -----Original Message-----
> From: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Sent: 2020年10月2日 19:44
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
>
> Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
> causes NetworkPkg build to fail due to lack of RngLib entry in
> NetworkPkg's .dsc file.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> ---
> NetworkPkg/NetworkPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 503d828f91e6..716d04fdadb2 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -40,6 +40,7 @@
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
>
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
> inf
>
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>
> + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
>
>
>
> !ifdef CONTINUOUS_INTEGRATION
>
> BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
>
> --
> 2.24.0.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
2020-10-09 8:41 ` Siyuan, Fu
@ 2020-10-09 9:13 ` Maciej Rabeda
0 siblings, 0 replies; 3+ messages in thread
From: Maciej Rabeda @ 2020-10-09 9:13 UTC (permalink / raw)
To: devel, siyuan.fu; +Cc: Wu, Jiaxin
Merged:
https://github.com/tianocore/edk2/commit/091ab12b340a05c99ce0e31d29293ce58c7014e2
https://github.com/tianocore/edk2/pull/994
On 09-Oct-20 10:41, Siyuan, Fu wrote:
> Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
>
>> -----Original Message-----
>> From: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Sent: 2020年10月2日 19:44
>> To: devel@edk2.groups.io
>> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
>> Subject: [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file.
>>
>> Recent change to OpensslLib (b5701a4c7a0fb185e0c5b9db9525939c78664bfd)
>> causes NetworkPkg build to fail due to lack of RngLib entry in
>> NetworkPkg's .dsc file.
>>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Signed-off-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> ---
>> NetworkPkg/NetworkPkg.dsc | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
>> index 503d828f91e6..716d04fdadb2 100644
>> --- a/NetworkPkg/NetworkPkg.dsc
>> +++ b/NetworkPkg/NetworkPkg.dsc
>> @@ -40,6 +40,7 @@
>> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>>
>>
>> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
>> inf
>>
>> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>>
>> + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf
>>
>>
>>
>> !ifdef CONTINUOUS_INTEGRATION
>>
>> BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
>>
>> --
>> 2.24.0.windows.2
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-09 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-02 11:44 [PATCH v1] NetworkPkg: Add RngLib entry to .dsc file Maciej Rabeda
2020-10-09 8:41 ` Siyuan, Fu
2020-10-09 9:13 ` [edk2-devel] " Maciej Rabeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox