public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 0/3] BaseTools: refactor to remove redundant
Date: Tue, 10 Apr 2018 07:20:05 -0700	[thread overview]
Message-ID: <cover.1523369916.git.jaben.carsey@intel.com> (raw)

Replace raw strings used in lots of places with predefined constants.
remove more out of date keys() usage.

Jaben Carsey (3):
  BaseTools: refactor and remove more keys() usage
  BaseTools: use predefined constants instead of local strings
  BaseTools: use existing contrants to replace raw strings in python
    code.

 BaseTools/Source/Python/AutoGen/AutoGen.py             |  24 +--
 BaseTools/Source/Python/AutoGen/BuildEngine.py         |  23 +--
 BaseTools/Source/Python/AutoGen/GenC.py                |  13 +-
 BaseTools/Source/Python/AutoGen/GenDepex.py            |   3 +-
 BaseTools/Source/Python/AutoGen/GenPcdDb.py            |  15 +-
 BaseTools/Source/Python/AutoGen/GenVar.py              |  15 +-
 BaseTools/Source/Python/Common/DataType.py             |   2 +
 BaseTools/Source/Python/GenFds/AprioriSection.py       |   3 +-
 BaseTools/Source/Python/GenFds/FdfParser.py            |  29 ++--
 BaseTools/Source/Python/GenFds/Ffs.py                  |   3 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py      |   5 +-
 BaseTools/Source/Python/GenFds/GenFds.py               |  13 +-
 BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py |   9 +-
 BaseTools/Source/Python/GenFds/Section.py              |   3 +-
 BaseTools/Source/Python/Workspace/DecBuildData.py      |   5 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py      | 173 ++++++++++----------
 BaseTools/Source/Python/Workspace/InfBuildData.py      |   9 +-
 BaseTools/Source/Python/Workspace/MetaFileParser.py    |  34 ++--
 BaseTools/Source/Python/Workspace/MetaFileTable.py     |  22 +--
 BaseTools/Source/Python/Workspace/WorkspaceDatabase.py |   6 +-
 BaseTools/Source/Python/build/BuildReport.py           |   5 +-
 21 files changed, 218 insertions(+), 196 deletions(-)

-- 
2.16.2.windows.1



             reply	other threads:[~2018-04-10 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 14:20 Jaben Carsey [this message]
2018-04-10 14:20 ` [PATCH v1 1/3] BaseTools: refactor and remove more keys() usage Jaben Carsey
2018-04-18  8:48   ` Zhu, Yonghong
2018-04-10 14:20 ` [PATCH v1 2/3] BaseTools: use predefined constants instead of local strings Jaben Carsey
2018-04-16  1:43   ` Zhu, Yonghong
2018-04-10 14:20 ` [PATCH v1 3/3] BaseTools: use existing contrants to replace raw strings in python code Jaben Carsey
2018-04-11  1:07   ` Zhu, Yonghong
2018-04-11 14:20     ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1523369916.git.jaben.carsey@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox