From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 76A882270D330 for ; Tue, 10 Apr 2018 07:20:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 07:20:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="190327377" Received: from jcarsey-desk1.amr.corp.intel.com ([10.7.159.141]) by orsmga004.jf.intel.com with ESMTP; 10 Apr 2018 07:20:09 -0700 From: Jaben Carsey To: edk2-devel@lists.01.org Date: Tue, 10 Apr 2018 07:20:05 -0700 Message-Id: X-Mailer: git-send-email 2.16.2.windows.1 Subject: [PATCH v1 0/3] BaseTools: refactor to remove redundant X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 14:20:10 -0000 Replace raw strings used in lots of places with predefined constants. remove more out of date keys() usage. Jaben Carsey (3): BaseTools: refactor and remove more keys() usage BaseTools: use predefined constants instead of local strings BaseTools: use existing contrants to replace raw strings in python code. BaseTools/Source/Python/AutoGen/AutoGen.py | 24 +-- BaseTools/Source/Python/AutoGen/BuildEngine.py | 23 +-- BaseTools/Source/Python/AutoGen/GenC.py | 13 +- BaseTools/Source/Python/AutoGen/GenDepex.py | 3 +- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 15 +- BaseTools/Source/Python/AutoGen/GenVar.py | 15 +- BaseTools/Source/Python/Common/DataType.py | 2 + BaseTools/Source/Python/GenFds/AprioriSection.py | 3 +- BaseTools/Source/Python/GenFds/FdfParser.py | 29 ++-- BaseTools/Source/Python/GenFds/Ffs.py | 3 +- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 5 +- BaseTools/Source/Python/GenFds/GenFds.py | 13 +- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 9 +- BaseTools/Source/Python/GenFds/Section.py | 3 +- BaseTools/Source/Python/Workspace/DecBuildData.py | 5 +- BaseTools/Source/Python/Workspace/DscBuildData.py | 173 ++++++++++---------- BaseTools/Source/Python/Workspace/InfBuildData.py | 9 +- BaseTools/Source/Python/Workspace/MetaFileParser.py | 34 ++-- BaseTools/Source/Python/Workspace/MetaFileTable.py | 22 +-- BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 6 +- BaseTools/Source/Python/build/BuildReport.py | 5 +- 21 files changed, 218 insertions(+), 196 deletions(-) -- 2.16.2.windows.1