public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jaben <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 0/2] BaseTools: refactor for code simplification
Date: Thu, 12 Apr 2018 17:02:09 -0700	[thread overview]
Message-ID: <cover.1523577634.git.jaben.carsey@intel.com> (raw)

- remove/replace more None comparisons to conforn to code style
- remove/replace .keys() calls to reduce the number of temporary
lists made from dictionaries

Jaben (2):
  BaseTools: fix None comparisons
  BaseTools: refactor and remove un-needed use of .keys() on
    dictionaries

 BaseTools/Source/Python/AutoGen/AutoGen.py                             | 34 +++++------
 BaseTools/Source/Python/AutoGen/GenC.py                                |  2 +-
 BaseTools/Source/Python/AutoGen/GenMake.py                             | 24 ++++----
 BaseTools/Source/Python/AutoGen/GenVar.py                              |  2 +-
 BaseTools/Source/Python/AutoGen/InfSectionParser.py                    |  6 +-
 BaseTools/Source/Python/BPDG/GenVpd.py                                 |  2 +-
 BaseTools/Source/Python/Common/EdkIIWorkspace.py                       |  5 +-
 BaseTools/Source/Python/Common/Expression.py                           |  4 +-
 BaseTools/Source/Python/Common/Misc.py                                 |  4 +-
 BaseTools/Source/Python/Common/Parsing.py                              | 13 ++---
 BaseTools/Source/Python/Common/String.py                               |  2 +-
 BaseTools/Source/Python/Common/VpdInfoFile.py                          |  8 +--
 BaseTools/Source/Python/GenFds/Capsule.py                              |  8 +--
 BaseTools/Source/Python/GenFds/CapsuleData.py                          | 10 ++--
 BaseTools/Source/Python/GenFds/Fd.py                                   |  4 +-
 BaseTools/Source/Python/GenFds/FdfParser.py                            | 18 +++---
 BaseTools/Source/Python/GenFds/FfsFileStatement.py                     |  6 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py                      |  2 +-
 BaseTools/Source/Python/GenFds/Fv.py                                   | 19 +++---
 BaseTools/Source/Python/GenFds/GenFds.py                               | 61 +++++++++-----------
 BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py                 |  4 +-
 BaseTools/Source/Python/GenFds/Region.py                               | 12 ++--
 BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKeys.py |  6 +-
 BaseTools/Source/Python/TargetTool/TargetTool.py                       |  8 +--
 BaseTools/Source/Python/Workspace/DscBuildData.py                      | 44 +++++++-------
 BaseTools/Source/Python/Workspace/InfBuildData.py                      |  5 +-
 BaseTools/Source/Python/Workspace/MetaFileParser.py                    |  4 +-
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py                   |  6 +-
 BaseTools/Source/Python/build/BuildReport.py                           |  4 +-
 BaseTools/Source/Python/build/build.py                                 | 22 ++++---
 30 files changed, 163 insertions(+), 186 deletions(-)

-- 
2.16.2.windows.1



             reply	other threads:[~2018-04-13  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13  0:02 Jaben [this message]
2018-04-13  0:02 ` [PATCH v1 1/2] BaseTools: fix None comparisons Jaben
2018-04-17 13:20   ` Zhu, Yonghong
2018-04-13  0:02 ` [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries Jaben
2018-04-17 13:25   ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1523577634.git.jaben.carsey@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox