From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D8D42267F0F7 for ; Thu, 12 Apr 2018 17:02:14 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2018 17:02:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="191109778" Received: from jcarsey-desk1.amr.corp.intel.com ([10.7.159.144]) by orsmga004.jf.intel.com with ESMTP; 12 Apr 2018 17:02:13 -0700 From: Jaben To: edk2-devel@lists.01.org Date: Thu, 12 Apr 2018 17:02:09 -0700 Message-Id: X-Mailer: git-send-email 2.16.2.windows.1 Subject: [PATCH v1 0/2] BaseTools: refactor for code simplification X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 00:02:14 -0000 - remove/replace more None comparisons to conforn to code style - remove/replace .keys() calls to reduce the number of temporary lists made from dictionaries Jaben (2): BaseTools: fix None comparisons BaseTools: refactor and remove un-needed use of .keys() on dictionaries BaseTools/Source/Python/AutoGen/AutoGen.py | 34 +++++------ BaseTools/Source/Python/AutoGen/GenC.py | 2 +- BaseTools/Source/Python/AutoGen/GenMake.py | 24 ++++---- BaseTools/Source/Python/AutoGen/GenVar.py | 2 +- BaseTools/Source/Python/AutoGen/InfSectionParser.py | 6 +- BaseTools/Source/Python/BPDG/GenVpd.py | 2 +- BaseTools/Source/Python/Common/EdkIIWorkspace.py | 5 +- BaseTools/Source/Python/Common/Expression.py | 4 +- BaseTools/Source/Python/Common/Misc.py | 4 +- BaseTools/Source/Python/Common/Parsing.py | 13 ++--- BaseTools/Source/Python/Common/String.py | 2 +- BaseTools/Source/Python/Common/VpdInfoFile.py | 8 +-- BaseTools/Source/Python/GenFds/Capsule.py | 8 +-- BaseTools/Source/Python/GenFds/CapsuleData.py | 10 ++-- BaseTools/Source/Python/GenFds/Fd.py | 4 +- BaseTools/Source/Python/GenFds/FdfParser.py | 18 +++--- BaseTools/Source/Python/GenFds/FfsFileStatement.py | 6 +- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 2 +- BaseTools/Source/Python/GenFds/Fv.py | 19 +++--- BaseTools/Source/Python/GenFds/GenFds.py | 61 +++++++++----------- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 4 +- BaseTools/Source/Python/GenFds/Region.py | 12 ++-- BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKeys.py | 6 +- BaseTools/Source/Python/TargetTool/TargetTool.py | 8 +-- BaseTools/Source/Python/Workspace/DscBuildData.py | 44 +++++++------- BaseTools/Source/Python/Workspace/InfBuildData.py | 5 +- BaseTools/Source/Python/Workspace/MetaFileParser.py | 4 +- BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 6 +- BaseTools/Source/Python/build/BuildReport.py | 4 +- BaseTools/Source/Python/build/build.py | 22 ++++--- 30 files changed, 163 insertions(+), 186 deletions(-) -- 2.16.2.windows.1