From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 00/27] BaseTools refactoring
Date: Fri, 20 Apr 2018 08:51:20 -0700 [thread overview]
Message-ID: <cover.1524239027.git.jaben.carsey@intel.com> (raw)
remove unused code/variables/file
move re.compile to eliminate recompiling same expression
replace string constants in code with predefined constants
(including sets, preferred for "in" testing, and lists of string constants)
(include making new constants, sets, and lists)
switch dict to defaultdict to eliminate initialization code
dont compare using "in [None,'']" as python does that by default
use a shared Component to Module map
Jaben Carsey (27):
BaseTools: Misc - refactor RegEx to minimize multiple compiling
BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple
compiling
BaseTools: Share RegEx between files
BaseTools: Workspace - refactor RegEx to minimize multiple compiling
BaseTools: Autogen - replace string constants with those from DataType
BaseTools: simplify if call
BaseTools: Workspace - refactor GetStructurePcdInfo
BaseTools: AutoGen - remove dictionary populated, but never accessed
BaseTools: AutoGen - remove unused variables.
BaseTools: Remove extra .keys()
BaseTools: Workspace/MetaFileParser - refactor dicts
BaseTools: remove dict from DscBuildData
BaseTools: replace string constants used for module types
BaseTools: Define and use a set for common list
BaseTools: Share a dictionary instead of keeping multiples
BaseTools: Replace EDK Component strings with predefined constant
BaseTools: DataType - cleanup list constants
BaseTools: Replace PCD type strings with predefined constant
BaseTools: Replace Binary File type strings with predefined constant
BaseTools: remove duplicate variable
BaseTools: replace string with predefined constant
BaseTools: remove redundant if comparison
BaseTools: AutoGen - use dafultdict instead of dict
BaseTools: GenFds - simplify testing for Hex number
BaseTools: AutoGen - use defaultdict to auto initialize
BaseTools: remove unused MigrationUtilities.py
BaseTools: CommonClass - remove unused classes
BaseTools/Source/Python/AutoGen/AutoGen.py | 153 +++---
BaseTools/Source/Python/AutoGen/BuildEngine.py | 10 +-
BaseTools/Source/Python/AutoGen/GenC.py | 170 +++---
BaseTools/Source/Python/AutoGen/GenDepex.py | 33 +-
BaseTools/Source/Python/AutoGen/GenMake.py | 2 -
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 12 +-
BaseTools/Source/Python/AutoGen/GenVar.py | 6 +-
BaseTools/Source/Python/Common/DataType.py | 54 +-
BaseTools/Source/Python/Common/Expression.py | 4 +-
BaseTools/Source/Python/Common/GlobalData.py | 1 +
BaseTools/Source/Python/Common/MigrationUtilities.py | 568 --------------------
BaseTools/Source/Python/Common/Misc.py | 26 +-
BaseTools/Source/Python/CommonDataClass/CommonClass.py | 397 +-------------
BaseTools/Source/Python/Ecc/Check.py | 6 +-
BaseTools/Source/Python/Ecc/Configuration.py | 2 +-
BaseTools/Source/Python/Ecc/c.py | 2 +-
BaseTools/Source/Python/GenFds/CompressSection.py | 3 +-
BaseTools/Source/Python/GenFds/DataSection.py | 8 +-
BaseTools/Source/Python/GenFds/DepexSection.py | 17 +-
BaseTools/Source/Python/GenFds/EfiSection.py | 25 +-
BaseTools/Source/Python/GenFds/Fd.py | 3 +-
BaseTools/Source/Python/GenFds/FdfParser.py | 121 ++---
BaseTools/Source/Python/GenFds/Ffs.py | 51 +-
BaseTools/Source/Python/GenFds/FfsInfStatement.py | 56 +-
BaseTools/Source/Python/GenFds/Fv.py | 6 +-
BaseTools/Source/Python/GenFds/FvImageSection.py | 5 +-
BaseTools/Source/Python/GenFds/GenFds.py | 10 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 40 +-
BaseTools/Source/Python/GenFds/GuidSection.py | 5 +-
BaseTools/Source/Python/GenFds/OptRomInfStatement.py | 3 +-
BaseTools/Source/Python/GenFds/Region.py | 5 +-
BaseTools/Source/Python/GenFds/Section.py | 46 +-
BaseTools/Source/Python/GenFds/UiSection.py | 3 +-
BaseTools/Source/Python/GenFds/VerSection.py | 3 +-
BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 23 +-
BaseTools/Source/Python/Makefile | 1 -
BaseTools/Source/Python/Trim/Trim.py | 2 +-
BaseTools/Source/Python/Workspace/DecBuildData.py | 22 +-
BaseTools/Source/Python/Workspace/DscBuildData.py | 51 +-
BaseTools/Source/Python/Workspace/InfBuildData.py | 74 +--
BaseTools/Source/Python/Workspace/MetaFileParser.py | 27 +-
BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 2 +-
BaseTools/Source/Python/build/BuildReport.py | 99 ++--
BaseTools/Source/Python/build/build.py | 16 +-
44 files changed, 583 insertions(+), 1590 deletions(-)
delete mode 100644 BaseTools/Source/Python/Common/MigrationUtilities.py
--
2.16.2.windows.1
next reply other threads:[~2018-04-20 15:51 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 15:51 Jaben Carsey [this message]
2018-04-20 15:51 ` [PATCH v1 01/27] BaseTools: Misc - refactor RegEx to minimize multiple compiling Jaben Carsey
2018-04-25 8:49 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 02/27] BaseTools: GenPatchPcdTable " Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 03/27] BaseTools: Share RegEx between files Jaben Carsey
2018-04-25 8:51 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 04/27] BaseTools: Workspace - refactor RegEx to minimize multiple compiling Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 05/27] BaseTools: Autogen - replace string constants with those from DataType Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 06/27] BaseTools: simplify if call Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 07/27] BaseTools: Workspace - refactor GetStructurePcdInfo Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 08/27] BaseTools: AutoGen - remove dictionary populated, but never accessed Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 09/27] BaseTools: AutoGen - remove unused variables Jaben Carsey
2018-04-25 8:52 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 10/27] BaseTools: Remove extra .keys() Jaben Carsey
2018-04-25 8:51 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 11/27] BaseTools: Workspace/MetaFileParser - refactor dicts Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 12/27] BaseTools: remove dict from DscBuildData Jaben Carsey
2018-04-25 8:50 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 13/27] BaseTools: replace string constants used for module types Jaben Carsey
2018-04-25 5:57 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 14/27] BaseTools: Define and use a set for common list Jaben Carsey
2018-05-02 6:48 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 15/27] BaseTools: Share a dictionary instead of keeping multiples Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 16/27] BaseTools: Replace EDK Component strings with predefined constant Jaben Carsey
2018-04-24 7:42 ` Zhu, Yonghong
2018-04-24 14:13 ` Carsey, Jaben
2018-04-20 15:51 ` [PATCH v1 17/27] BaseTools: DataType - cleanup list constants Jaben Carsey
2018-05-04 11:14 ` Laszlo Ersek
2018-05-04 14:18 ` Carsey, Jaben
2018-05-04 15:03 ` Laszlo Ersek
2018-04-20 15:51 ` [PATCH v1 18/27] BaseTools: Replace PCD type strings with predefined constant Jaben Carsey
2018-04-25 6:00 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 19/27] BaseTools: Replace Binary File " Jaben Carsey
2018-04-24 7:38 ` Zhu, Yonghong
2018-04-24 14:12 ` Carsey, Jaben
2018-04-20 15:51 ` [PATCH v1 20/27] BaseTools: remove duplicate variable Jaben Carsey
2018-04-25 8:51 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 21/27] BaseTools: replace string with predefined constant Jaben Carsey
2018-04-25 6:04 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 22/27] BaseTools: remove redundant if comparison Jaben Carsey
2018-05-02 6:49 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 23/27] BaseTools: AutoGen - use dafultdict instead of dict Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 24/27] BaseTools: GenFds - simplify testing for Hex number Jaben Carsey
2018-04-25 8:51 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize Jaben Carsey
2018-04-25 8:52 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py Jaben Carsey
2018-05-02 6:49 ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 27/27] BaseTools: CommonClass - remove unused classes Jaben Carsey
2018-04-25 8:51 ` Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1524239027.git.jaben.carsey@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox