From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 00/42] BaseTools: refactoring patches
Date: Fri, 27 Apr 2018 15:32:14 -0700 [thread overview]
Message-ID: <cover.1524868033.git.jaben.carsey@intel.com> (raw)
first goal in this series is reduction in meaningless memory allocation or
use. An example is creating lists from iterators for the sole purpose of
passing into anthoer function where the function would take the iterator.
Another example is making a list just to create a set.
second goal is begining of organizational changes. This includes moving
functions from one class to another if the function operates primarily on the
second class' data. Another example is if a class has a small function only
called in __init__, the logic can just be added to __init__.
imnportant note: one patch removes lots of trailing whitepsace, without making
any other changes.
Jaben Carsey (42):
BaseTools: FdfParser - update to remove duplicate constant value
BaseTools: AutoGen - update to remove duplicate constant value
BaseTools: check before accessing members in __eq__
BaseTools: this function has no purpose.
BaseTools: AutoGen - refactor assemble_variable
BaseTools: AutoGen - refactor dictionary access
BaseTools: AutoGen - GenVar refactor static methods
BaseTools: AutoGen - share StripComments API
BaseTools: AutoGen - refactor class factory
BaseTools: Eot - remove unused lists
BaseTools: Eot - refactor global data
BaseTools: AutoGen - remove global line
BaseTools: AutoGen - UniClassObject refactor static methods
BaseTools: refactor to use list not dict
BaseTools: eliminate {} from dictionary contructor call
BaseTools: remove Compound statements
BaseTools: Workspace - refactor a dict
BaseTools: move PCD size calculation functions to PcdClassObject
BaseTools: AutoGen - refactor out functions only called in __init__
BaseTools: AutoGen - refactor out a list
BaseTools: AutoGen - refactor out a useless class
BaseTools: AutoGen - no need to recompute
BaseTools: refactor __init__ functions to not compute temporary
variable
BaseTools: AutoGen - remove function no one calls
BaseTools: AutoGen - move function to clean file namespace
BaseTools: AutoGen - remove another function no one calls
BaseTools: Refactor to share GUID packing function
BaseTools: AutoGen - refactor function to remove extra variables
BaseTools: AutoGen - refactor more functions only called in __init__
BaseTools: remove unused member variable
BaseTools: remove redundant content in InfSectionParser
BaseTools: trim whitespace
BaseTools: AutoGen - add Opcode constants
BaseTools: standardize GUID and pack size
BaseTools: remove unused variable
BaseTools: GenFds - use existing shared string
BaseTools: missed a copyright update
BaseTools: Remove lists form set construction
BaseTools: refactor Depex optomization
BaseTools: dont make iterator into list if not needed
BaseTools: create base expression class
BaseTools: use set instead of list
BaseTools/Source/Python/AutoGen/AutoGen.py | 200 +--
BaseTools/Source/Python/AutoGen/BuildEngine.py | 25 +-
BaseTools/Source/Python/AutoGen/GenC.py | 111 +-
BaseTools/Source/Python/AutoGen/GenDepex.py | 127 +-
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 333 ++---
BaseTools/Source/Python/AutoGen/GenVar.py | 124 +-
BaseTools/Source/Python/AutoGen/IdfClassObject.py | 113 +-
BaseTools/Source/Python/AutoGen/InfSectionParser.py | 21 +-
BaseTools/Source/Python/AutoGen/StrGather.py | 26 +-
BaseTools/Source/Python/AutoGen/UniClassObject.py | 61 +-
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 141 +-
BaseTools/Source/Python/BPDG/BPDG.py | 56 +-
BaseTools/Source/Python/BPDG/GenVpd.py | 132 +-
BaseTools/Source/Python/BPDG/StringTable.py | 10 +-
BaseTools/Source/Python/Common/BuildVersion.py | 6 +-
BaseTools/Source/Python/Common/DataType.py | 26 +-
BaseTools/Source/Python/Common/Database.py | 17 +-
BaseTools/Source/Python/Common/Expression.py | 97 +-
BaseTools/Source/Python/Common/MigrationUtilities.py | 66 +-
BaseTools/Source/Python/Common/Misc.py | 109 +-
BaseTools/Source/Python/Common/MultipleWorkspace.py | 17 +-
BaseTools/Source/Python/Common/RangeExpression.py | 159 +--
BaseTools/Source/Python/Common/String.py | 14 +-
BaseTools/Source/Python/Common/ToolDefClassObject.py | 5 +-
BaseTools/Source/Python/Common/VariableAttributes.py | 12 +-
BaseTools/Source/Python/Common/VpdInfoFile.py | 84 +-
BaseTools/Source/Python/CommonDataClass/FdfClass.py | 28 +-
BaseTools/Source/Python/Ecc/CLexer.py | 8 +-
BaseTools/Source/Python/Ecc/CParser.py | 1468 ++++++++++----------
BaseTools/Source/Python/Ecc/Check.py | 22 +-
BaseTools/Source/Python/Ecc/CodeFragment.py | 3 +-
BaseTools/Source/Python/Ecc/CodeFragmentCollector.py | 124 +-
BaseTools/Source/Python/Ecc/Configuration.py | 10 +-
BaseTools/Source/Python/Ecc/Ecc.py | 26 +-
BaseTools/Source/Python/Ecc/Exception.py | 14 +-
BaseTools/Source/Python/Ecc/FileProfile.py | 5 +-
BaseTools/Source/Python/Ecc/MetaDataParser.py | 46 +-
BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaDataTable.py | 4 +-
BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileParser.py | 100 +-
BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileTable.py | 88 +-
BaseTools/Source/Python/Ecc/Xml/XmlRoutines.py | 4 +-
BaseTools/Source/Python/Ecc/Xml/__init__.py | 6 +-
BaseTools/Source/Python/Ecc/c.py | 12 +-
BaseTools/Source/Python/Eot/CLexer.py | 8 +-
BaseTools/Source/Python/Eot/CParser.py | 1468 ++++++++++----------
BaseTools/Source/Python/Eot/Eot.py | 21 +-
BaseTools/Source/Python/Eot/EotGlobalData.py | 41 -
BaseTools/Source/Python/Eot/Report.py | 4 +-
BaseTools/Source/Python/GenFds/Capsule.py | 2 +-
BaseTools/Source/Python/GenFds/CapsuleData.py | 18 +-
BaseTools/Source/Python/GenFds/EfiSection.py | 8 +-
BaseTools/Source/Python/GenFds/Fd.py | 2 +-
BaseTools/Source/Python/GenFds/FdfParser.py | 173 ++-
BaseTools/Source/Python/GenFds/Ffs.py | 10 +-
BaseTools/Source/Python/GenFds/FfsFileStatement.py | 4 +-
BaseTools/Source/Python/GenFds/FfsInfStatement.py | 62 +-
BaseTools/Source/Python/GenFds/Fv.py | 70 +-
BaseTools/Source/Python/GenFds/GenFds.py | 32 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 36 +-
BaseTools/Source/Python/GenFds/GuidSection.py | 2 +-
BaseTools/Source/Python/GenFds/OptRomFileStatement.py | 6 +-
BaseTools/Source/Python/GenFds/OptRomInfStatement.py | 21 +-
BaseTools/Source/Python/GenFds/OptionRom.py | 49 +-
BaseTools/Source/Python/GenFds/Region.py | 4 +-
BaseTools/Source/Python/GenFds/Section.py | 2 +-
BaseTools/Source/Python/GenFds/Vtf.py | 18 +-
BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 28 +-
BaseTools/Source/Python/PatchPcdValue/PatchPcdValue.py | 6 +-
BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKeys.py | 34 +-
BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 30 +-
BaseTools/Source/Python/Table/Table.py | 20 +-
BaseTools/Source/Python/Table/TableDataModel.py | 14 +-
BaseTools/Source/Python/Table/TableDec.py | 12 +-
BaseTools/Source/Python/Table/TableDsc.py | 12 +-
BaseTools/Source/Python/Table/TableEotReport.py | 6 +-
BaseTools/Source/Python/Table/TableFdf.py | 12 +-
BaseTools/Source/Python/Table/TableFile.py | 12 +-
BaseTools/Source/Python/Table/TableFunction.py | 8 +-
BaseTools/Source/Python/Table/TableIdentifier.py | 4 +-
BaseTools/Source/Python/Table/TableInf.py | 12 +-
BaseTools/Source/Python/Table/TablePcd.py | 4 +-
BaseTools/Source/Python/Table/TableReport.py | 6 +-
BaseTools/Source/Python/TargetTool/TargetTool.py | 24 +-
BaseTools/Source/Python/Trim/Trim.py | 20 +-
BaseTools/Source/Python/Workspace/BuildClassObject.py | 57 +-
BaseTools/Source/Python/Workspace/DscBuildData.py | 41 +-
BaseTools/Source/Python/Workspace/InfBuildData.py | 12 +-
BaseTools/Source/Python/Workspace/MetaDataTable.py | 4 +-
BaseTools/Source/Python/Workspace/MetaFileParser.py | 2 +-
BaseTools/Source/Python/Workspace/MetaFileTable.py | 88 +-
BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 24 +-
BaseTools/Source/Python/build/BuildReport.py | 36 +-
BaseTools/Source/Python/build/build.py | 19 +-
BaseTools/Source/Python/sitecustomize.py | 2 +-
94 files changed, 3207 insertions(+), 3463 deletions(-)
--
2.16.2.windows.1
next reply other threads:[~2018-04-27 22:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 22:32 Jaben Carsey [this message]
2018-04-27 22:32 ` [PATCH v1 01/42] BaseTools: FdfParser - update to remove duplicate constant value Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 02/42] BaseTools: AutoGen " Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 03/42] BaseTools: check before accessing members in __eq__ Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 04/42] BaseTools: this function has no purpose Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 05/42] BaseTools: AutoGen - refactor assemble_variable Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 06/42] BaseTools: AutoGen - refactor dictionary access Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 07/42] BaseTools: AutoGen - GenVar refactor static methods Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 08/42] BaseTools: AutoGen - share StripComments API Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 09/42] BaseTools: AutoGen - refactor class factory Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 10/42] BaseTools: Eot - remove unused lists Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 11/42] BaseTools: Eot - refactor global data Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 12/42] BaseTools: AutoGen - remove global line Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 13/42] BaseTools: AutoGen - UniClassObject refactor static methods Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 14/42] BaseTools: refactor to use list not dict Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 15/42] BaseTools: eliminate {} from dictionary contructor call Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 16/42] BaseTools: remove Compound statements Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 17/42] BaseTools: Workspace - refactor a dict Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 18/42] BaseTools: move PCD size calculation functions to PcdClassObject Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 19/42] BaseTools: AutoGen - refactor out functions only called in __init__ Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 20/42] BaseTools: AutoGen - refactor out a list Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 21/42] BaseTools: AutoGen - refactor out a useless class Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 22/42] BaseTools: AutoGen - no need to recompute Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 23/42] BaseTools: refactor __init__ functions to not compute temporary variable Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 24/42] BaseTools: AutoGen - remove function no one calls Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 25/42] BaseTools: AutoGen - move function to clean file namespace Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 26/42] BaseTools: AutoGen - remove another function no one calls Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 27/42] BaseTools: Refactor to share GUID packing function Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 28/42] BaseTools: AutoGen - refactor function to remove extra variables Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 29/42] BaseTools: AutoGen - refactor more functions only called in __init__ Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 30/42] BaseTools: remove unused member variable Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 31/42] BaseTools: remove redundant content in InfSectionParser Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 32/42] BaseTools: trim whitespace Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 33/42] BaseTools: AutoGen - add Opcode constants Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 34/42] BaseTools: standardize GUID and pack size Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 35/42] BaseTools: remove unused variable Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 36/42] BaseTools: GenFds - use existing shared string Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 37/42] BaseTools: missed a copyright update Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 38/42] BaseTools: Remove lists form set construction Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 39/42] BaseTools: refactor Depex optomization Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 40/42] BaseTools: dont make iterator into list if not needed Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 41/42] BaseTools: create base expression class Jaben Carsey
2018-04-27 22:32 ` [PATCH v1 42/42] BaseTools: use set instead of list Jaben Carsey
2018-05-04 4:33 ` [PATCH v1 00/42] BaseTools: refactoring patches Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1524868033.git.jaben.carsey@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox