From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E26BC2034C8AD for ; Fri, 27 Apr 2018 15:32:59 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 15:32:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,336,1520924400"; d="scan'208";a="54252770" Received: from jcarsey-desk1.amr.corp.intel.com ([10.7.159.144]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2018 15:32:59 -0700 From: Jaben Carsey To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 15:32:14 -0700 Message-Id: X-Mailer: git-send-email 2.16.2.windows.1 Subject: [PATCH v1 00/42] BaseTools: refactoring patches X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 22:33:00 -0000 first goal in this series is reduction in meaningless memory allocation or use. An example is creating lists from iterators for the sole purpose of passing into anthoer function where the function would take the iterator. Another example is making a list just to create a set. second goal is begining of organizational changes. This includes moving functions from one class to another if the function operates primarily on the second class' data. Another example is if a class has a small function only called in __init__, the logic can just be added to __init__. imnportant note: one patch removes lots of trailing whitepsace, without making any other changes. Jaben Carsey (42): BaseTools: FdfParser - update to remove duplicate constant value BaseTools: AutoGen - update to remove duplicate constant value BaseTools: check before accessing members in __eq__ BaseTools: this function has no purpose. BaseTools: AutoGen - refactor assemble_variable BaseTools: AutoGen - refactor dictionary access BaseTools: AutoGen - GenVar refactor static methods BaseTools: AutoGen - share StripComments API BaseTools: AutoGen - refactor class factory BaseTools: Eot - remove unused lists BaseTools: Eot - refactor global data BaseTools: AutoGen - remove global line BaseTools: AutoGen - UniClassObject refactor static methods BaseTools: refactor to use list not dict BaseTools: eliminate {} from dictionary contructor call BaseTools: remove Compound statements BaseTools: Workspace - refactor a dict BaseTools: move PCD size calculation functions to PcdClassObject BaseTools: AutoGen - refactor out functions only called in __init__ BaseTools: AutoGen - refactor out a list BaseTools: AutoGen - refactor out a useless class BaseTools: AutoGen - no need to recompute BaseTools: refactor __init__ functions to not compute temporary variable BaseTools: AutoGen - remove function no one calls BaseTools: AutoGen - move function to clean file namespace BaseTools: AutoGen - remove another function no one calls BaseTools: Refactor to share GUID packing function BaseTools: AutoGen - refactor function to remove extra variables BaseTools: AutoGen - refactor more functions only called in __init__ BaseTools: remove unused member variable BaseTools: remove redundant content in InfSectionParser BaseTools: trim whitespace BaseTools: AutoGen - add Opcode constants BaseTools: standardize GUID and pack size BaseTools: remove unused variable BaseTools: GenFds - use existing shared string BaseTools: missed a copyright update BaseTools: Remove lists form set construction BaseTools: refactor Depex optomization BaseTools: dont make iterator into list if not needed BaseTools: create base expression class BaseTools: use set instead of list BaseTools/Source/Python/AutoGen/AutoGen.py | 200 +-- BaseTools/Source/Python/AutoGen/BuildEngine.py | 25 +- BaseTools/Source/Python/AutoGen/GenC.py | 111 +- BaseTools/Source/Python/AutoGen/GenDepex.py | 127 +- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 333 ++--- BaseTools/Source/Python/AutoGen/GenVar.py | 124 +- BaseTools/Source/Python/AutoGen/IdfClassObject.py | 113 +- BaseTools/Source/Python/AutoGen/InfSectionParser.py | 21 +- BaseTools/Source/Python/AutoGen/StrGather.py | 26 +- BaseTools/Source/Python/AutoGen/UniClassObject.py | 61 +- BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 141 +- BaseTools/Source/Python/BPDG/BPDG.py | 56 +- BaseTools/Source/Python/BPDG/GenVpd.py | 132 +- BaseTools/Source/Python/BPDG/StringTable.py | 10 +- BaseTools/Source/Python/Common/BuildVersion.py | 6 +- BaseTools/Source/Python/Common/DataType.py | 26 +- BaseTools/Source/Python/Common/Database.py | 17 +- BaseTools/Source/Python/Common/Expression.py | 97 +- BaseTools/Source/Python/Common/MigrationUtilities.py | 66 +- BaseTools/Source/Python/Common/Misc.py | 109 +- BaseTools/Source/Python/Common/MultipleWorkspace.py | 17 +- BaseTools/Source/Python/Common/RangeExpression.py | 159 +-- BaseTools/Source/Python/Common/String.py | 14 +- BaseTools/Source/Python/Common/ToolDefClassObject.py | 5 +- BaseTools/Source/Python/Common/VariableAttributes.py | 12 +- BaseTools/Source/Python/Common/VpdInfoFile.py | 84 +- BaseTools/Source/Python/CommonDataClass/FdfClass.py | 28 +- BaseTools/Source/Python/Ecc/CLexer.py | 8 +- BaseTools/Source/Python/Ecc/CParser.py | 1468 ++++++++++---------- BaseTools/Source/Python/Ecc/Check.py | 22 +- BaseTools/Source/Python/Ecc/CodeFragment.py | 3 +- BaseTools/Source/Python/Ecc/CodeFragmentCollector.py | 124 +- BaseTools/Source/Python/Ecc/Configuration.py | 10 +- BaseTools/Source/Python/Ecc/Ecc.py | 26 +- BaseTools/Source/Python/Ecc/Exception.py | 14 +- BaseTools/Source/Python/Ecc/FileProfile.py | 5 +- BaseTools/Source/Python/Ecc/MetaDataParser.py | 46 +- BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaDataTable.py | 4 +- BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileParser.py | 100 +- BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileTable.py | 88 +- BaseTools/Source/Python/Ecc/Xml/XmlRoutines.py | 4 +- BaseTools/Source/Python/Ecc/Xml/__init__.py | 6 +- BaseTools/Source/Python/Ecc/c.py | 12 +- BaseTools/Source/Python/Eot/CLexer.py | 8 +- BaseTools/Source/Python/Eot/CParser.py | 1468 ++++++++++---------- BaseTools/Source/Python/Eot/Eot.py | 21 +- BaseTools/Source/Python/Eot/EotGlobalData.py | 41 - BaseTools/Source/Python/Eot/Report.py | 4 +- BaseTools/Source/Python/GenFds/Capsule.py | 2 +- BaseTools/Source/Python/GenFds/CapsuleData.py | 18 +- BaseTools/Source/Python/GenFds/EfiSection.py | 8 +- BaseTools/Source/Python/GenFds/Fd.py | 2 +- BaseTools/Source/Python/GenFds/FdfParser.py | 173 ++- BaseTools/Source/Python/GenFds/Ffs.py | 10 +- BaseTools/Source/Python/GenFds/FfsFileStatement.py | 4 +- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 62 +- BaseTools/Source/Python/GenFds/Fv.py | 70 +- BaseTools/Source/Python/GenFds/GenFds.py | 32 +- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 36 +- BaseTools/Source/Python/GenFds/GuidSection.py | 2 +- BaseTools/Source/Python/GenFds/OptRomFileStatement.py | 6 +- BaseTools/Source/Python/GenFds/OptRomInfStatement.py | 21 +- BaseTools/Source/Python/GenFds/OptionRom.py | 49 +- BaseTools/Source/Python/GenFds/Region.py | 4 +- BaseTools/Source/Python/GenFds/Section.py | 2 +- BaseTools/Source/Python/GenFds/Vtf.py | 18 +- BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 28 +- BaseTools/Source/Python/PatchPcdValue/PatchPcdValue.py | 6 +- BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256GenerateKeys.py | 34 +- BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 30 +- BaseTools/Source/Python/Table/Table.py | 20 +- BaseTools/Source/Python/Table/TableDataModel.py | 14 +- BaseTools/Source/Python/Table/TableDec.py | 12 +- BaseTools/Source/Python/Table/TableDsc.py | 12 +- BaseTools/Source/Python/Table/TableEotReport.py | 6 +- BaseTools/Source/Python/Table/TableFdf.py | 12 +- BaseTools/Source/Python/Table/TableFile.py | 12 +- BaseTools/Source/Python/Table/TableFunction.py | 8 +- BaseTools/Source/Python/Table/TableIdentifier.py | 4 +- BaseTools/Source/Python/Table/TableInf.py | 12 +- BaseTools/Source/Python/Table/TablePcd.py | 4 +- BaseTools/Source/Python/Table/TableReport.py | 6 +- BaseTools/Source/Python/TargetTool/TargetTool.py | 24 +- BaseTools/Source/Python/Trim/Trim.py | 20 +- BaseTools/Source/Python/Workspace/BuildClassObject.py | 57 +- BaseTools/Source/Python/Workspace/DscBuildData.py | 41 +- BaseTools/Source/Python/Workspace/InfBuildData.py | 12 +- BaseTools/Source/Python/Workspace/MetaDataTable.py | 4 +- BaseTools/Source/Python/Workspace/MetaFileParser.py | 2 +- BaseTools/Source/Python/Workspace/MetaFileTable.py | 88 +- BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 24 +- BaseTools/Source/Python/build/BuildReport.py | 36 +- BaseTools/Source/Python/build/build.py | 19 +- BaseTools/Source/Python/sitecustomize.py | 2 +- 94 files changed, 3207 insertions(+), 3463 deletions(-) -- 2.16.2.windows.1