public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jaben Carsey <jaben.carsey@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 0/7] BaseTools/GenFds: cleanup GenFds
Date: Mon, 24 Sep 2018 07:28:11 -0700	[thread overview]
Message-ID: <cover.1537799017.git.jaben.carsey@intel.com> (raw)

Cleanup to many files for GenFds. No command line visible changes are included.
1) refactor imports to reduce namespace clutter.
2) refactor to use existing sharable objects (and create a few new)
3) eliminate shadowing of names
4) remove double underscored private methods for PEP8
5) eliminate unused code/parameters/variables
6) add standard warnings and use them for common code

Jaben Carsey (7):
  BaseTools/GenFds: cleanup GenFds
  BaseTools/GenFds: change objects to sets
  Basetools/GenFds: refactor class FV
  BaseTools/GenFds: remove MacroDict parameter
  BaseTools/GenFds: refactor FdfParser warnings
  BaseTools/GenFds: Remove duplicate function calls
  BaseTools/GenFds: create and use new variable in FdfParser

 BaseTools/Source/Python/CommonDataClass/FdfClass.py    |   73 -
 BaseTools/Source/Python/Eot/Eot.py                     |   11 +-
 BaseTools/Source/Python/GenFds/AprioriSection.py       |   45 +-
 BaseTools/Source/Python/GenFds/Capsule.py              |   26 +-
 BaseTools/Source/Python/GenFds/CapsuleData.py          |    1 -
 BaseTools/Source/Python/GenFds/CompressSection.py      |    4 +-
 BaseTools/Source/Python/GenFds/DataSection.py          |    4 +-
 BaseTools/Source/Python/GenFds/DepexSection.py         |    5 +-
 BaseTools/Source/Python/GenFds/EfiSection.py           |   16 +-
 BaseTools/Source/Python/GenFds/FdfParser.py            | 3748 ++++++++++----------
 BaseTools/Source/Python/GenFds/Ffs.py                  |   82 +-
 BaseTools/Source/Python/GenFds/FfsFileStatement.py     |   37 +-
 BaseTools/Source/Python/GenFds/FfsInfStatement.py      |   10 +-
 BaseTools/Source/Python/GenFds/Fv.py                   |   54 +-
 BaseTools/Source/Python/GenFds/FvImageSection.py       |    6 +-
 BaseTools/Source/Python/GenFds/GenFds.py               |  160 +-
 BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py |  208 +-
 BaseTools/Source/Python/GenFds/GuidSection.py          |    4 +-
 BaseTools/Source/Python/GenFds/OptionRom.py            |    6 +-
 BaseTools/Source/Python/GenFds/Region.py               |   12 +-
 BaseTools/Source/Python/GenFds/UiSection.py            |    4 +-
 BaseTools/Source/Python/GenFds/VerSection.py           |   16 +-
 BaseTools/Source/Python/GenFds/Vtf.py                  |   48 +-
 BaseTools/Source/Python/build/BuildReport.py           |    5 +-
 24 files changed, 2196 insertions(+), 2389 deletions(-)

-- 
2.16.2.windows.1



             reply	other threads:[~2018-09-24 14:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 14:28 Jaben Carsey [this message]
2018-09-24 14:28 ` [PATCH v1 1/7] BaseTools/GenFds: cleanup GenFds Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 2/7] BaseTools/GenFds: change objects to sets Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 3/7] Basetools/GenFds: refactor class FV Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 4/7] BaseTools/GenFds: remove MacroDict parameter Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 5/7] BaseTools/GenFds: refactor FdfParser warnings Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls Jaben Carsey
2018-09-25 13:45   ` Feng, Bob C
2018-09-24 14:28 ` [PATCH v1 7/7] BaseTools/GenFds: create and use new variable in FdfParser Jaben Carsey
2018-09-25 13:45   ` Feng, Bob C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1537799017.git.jaben.carsey@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox