From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=216.228.121.143; helo=hqemgate14.nvidia.com; envelope-from=ashishsingha@nvidia.com; receiver=edk2-devel@lists.01.org Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E2D221197376 for ; Fri, 4 Jan 2019 15:06:36 -0800 (PST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 04 Jan 2019 15:06:24 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 04 Jan 2019 15:06:36 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 04 Jan 2019 15:06:36 -0800 Received: from HQMAIL108.nvidia.com (172.18.146.13) by HQMAIL106.nvidia.com (172.18.146.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 4 Jan 2019 23:06:35 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL108.nvidia.com (172.18.146.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 4 Jan 2019 23:06:35 +0000 Received: from ashishsingha-lnx.nvidia.com (Not Verified[10.28.48.147]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Fri, 04 Jan 2019 15:06:35 -0800 From: Ashish Singhal To: CC: Ashish Singhal Date: Fri, 4 Jan 2019 16:06:29 -0700 Message-ID: X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1546643185; bh=DJ+T4sGASmTIgyYco29Gsbe1RhYX+OCTWx2YLyz+bTU=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=cxBktddyLtflcHVvCxh4OylxLC1PKCKtPBjgzxSysGNTw623QZYUahNfcdY3buvFz eRgjirpvO7WP7jFq/zN5w1D1qgEBqLzYIVcLq7zqGGdMxDUcuyWuO2aXZtkmO+hY3o OJzoiDTFy3wP8dUC/81a2dRv78A56IvgPZW1UHDbVA2m6sbAbnyKuq9sewhdAvWT5k b5iurn4dR2UYzT3Ww42i9jmGpWGIFI9gwYWdZXgR40rqJ7pWrMPaJiM57z4YzBWoOb ML1RWumw1pn84MqZgrLehLfkc6l2DnB6rc9ymSc6YMG1K42LuZQhh12XsiPvtRG+44 vCS7AvwRwjL9Q== Subject: [PATCH v2 0/4] Provide UEFILib functions for protocol uninstallation. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 23:06:36 -0000 Content-Type: text/plain An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after initialization failure was not done right. Bug 1428 was filed in this regard. As per discussions with Mike, it was also discussed that having UEFILib provide protocol uninstallation abstraction would help to avoid these issues in the future. Bug 1429 was found to track this. The first 2 patches take care of this. Patch number 3 simplifies the UEFILib protocol installation and uninstallation abstraction by adding a helper function doing operations instead of every public function. Patch set 4 uses the updated uninstallation interfaces as a result of patch 3. Ashish Singhal (4): MdePkg/UefiLib: Abstract driver model protocol uninstallation NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. MdePkg/UefiLib: Simplify protocol un/installation abstraction NetworkPkg/IScsiDxe: Update UEFILib Usage MdePkg/Include/Library/UefiLib.h | 127 ++++ MdePkg/Library/UefiLib/UefiDriverModel.c | 1210 +++++++++--------------------- NetworkPkg/IScsiDxe/IScsiDriver.c | 37 +- 3 files changed, 489 insertions(+), 885 deletions(-) -- 2.7.4