public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ashish Singhal <ashishsingha@nvidia.com>
To: <edk2-devel@lists.01.org>
Cc: Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.
Date: Sun, 6 Jan 2019 21:37:33 -0700	[thread overview]
Message-ID: <cover.1546835541.git.ashishsingha@nvidia.com> (raw)

An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after
initialization failure was not done right. Bug 1428 was filed in this regard.
As per discussions with Mike, it was also discussed that having UEFILib
provide protocol uninstallation abstraction would help to avoid these
issues in the future. Bug 1429 was found to track this. The first 2 patches
take care of this.

Patch number 1 also simplifies the UEFILib protocol installation and
uninstallation abstraction by adding a helper function doing operations
instead of every public function.

Ashish Singhal (2):
  MdePkg/UefiLib: Abstract driver model protocol uninstallation
  NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

 MdePkg/Include/Library/UefiLib.h         |  103 +++
 MdePkg/Library/UefiLib/UefiDriverModel.c | 1186 ++++++++----------------------
 NetworkPkg/IScsiDxe/IScsiDriver.c        |   31 +-
 3 files changed, 435 insertions(+), 885 deletions(-)

-- 
2.7.4



             reply	other threads:[~2019-01-07  4:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07  4:37 Ashish Singhal [this message]
2019-01-07  4:37 ` [PATCH v3 1/2] MdePkg/UefiLib: Abstract driver model protocol uninstallation Ashish Singhal
2019-01-07  4:37 ` [PATCH v3 2/2] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols Ashish Singhal
2019-01-07 14:01 ` [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation Ashish Singhal
2019-01-07 22:22   ` Kinney, Michael D
2019-01-07 22:50     ` Ashish Singhal
2019-01-08 16:25       ` Kinney, Michael D
2019-01-08 17:24         ` Ashish Singhal
2019-01-09  2:57           ` Kinney, Michael D
2019-01-09  3:02             ` Ashish Singhal
2019-02-04 20:18               ` Ashish Singhal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1546835541.git.ashishsingha@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox