From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH v3 0/2] Move FIT based microcode shadow to platform PEIM
Date: Thu, 13 Feb 2020 09:56:54 +0800 [thread overview]
Message-ID: <cover.1581558876.git.siyuan.fu@intel.com> (raw)
V2 Changes:
Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID.
Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform
microcode shadow PPI/Protocol is found.
Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni
V3 Changes
Add comments to DXE version PlatformShadowMicrocode().
Commit c7c964b and dd01704 add header file for FIT table and update
MpInitLib to support FIT based microcode shadow operation. There are
comments that FIT is Intel specific specification instead of industry
standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg.
So this patch adds a platform PPI for the microcode shadow logic, and
remove the FIT related code from EDK2.
The FIT based microcode shadow support will be implemented as a new
platform PEIM in IntelSiliconPkg in edk2-platforms.
This patch doesn't provide a DXE version shadow microcode protocol,
a platform which only uses DxeMpInitLib instance only supports PCD
based microcode shadowing.
A detailed design doc can be found here:
https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20
the%202nd%20Microcode%20FV%20Flash%20Region.pdf
[Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from
MpInitLib.
[Patch 2/2] MdePkg: Remove FIT table industry standard header file.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Siyuan Fu (2):
UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
MdePkg: Remove FIT table industry standard header file.
.../IndustryStandard/FirmwareInterfaceTable.h | 76 -------------
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++++++++++
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 -
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 26 ++++-
UefiCpuPkg/Library/MpInitLib/Microcode.c | 105 +-----------------
UefiCpuPkg/Library/MpInitLib/MpLib.h | 19 +++-
UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 4 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 68 ++++++++++++
UefiCpuPkg/UefiCpuPkg.dec | 11 +-
UefiCpuPkg/UefiCpuPkg.uni | 6 -
10 files changed, 183 insertions(+), 199 deletions(-)
delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h
--
2.19.1.windows.1
next reply other threads:[~2020-02-13 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 1:56 Siyuan, Fu [this message]
2020-02-13 1:56 ` [PATCH v3 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib Siyuan, Fu
2020-02-13 23:46 ` [edk2-devel] " Michael D Kinney
2020-02-13 1:56 ` [PATCH v3 2/2] MdePkg: Remove FIT table industry standard header file Siyuan, Fu
2020-02-13 23:46 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1581558876.git.siyuan.fu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox