From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.446.1581559020778506557 for ; Wed, 12 Feb 2020 17:57:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: siyuan.fu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 17:57:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,434,1574150400"; d="scan'208";a="266893977" Received: from shwdeopenpsi787.ccr.corp.intel.com ([10.239.158.56]) by fmsmga002.fm.intel.com with ESMTP; 12 Feb 2020 17:56:58 -0800 From: "Siyuan, Fu" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek , Michael D Kinney , Liming Gao Subject: [PATCH v3 0/2] Move FIT based microcode shadow to platform PEIM Date: Thu, 13 Feb 2020 09:56:54 +0800 Message-Id: X-Mailer: git-send-email 2.19.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit V2 Changes: Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID. Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform microcode shadow PPI/Protocol is found. Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni V3 Changes Add comments to DXE version PlatformShadowMicrocode(). Commit c7c964b and dd01704 add header file for FIT table and update MpInitLib to support FIT based microcode shadow operation. There are comments that FIT is Intel specific specification instead of industry standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. So this patch adds a platform PPI for the microcode shadow logic, and remove the FIT related code from EDK2. The FIT based microcode shadow support will be implemented as a new platform PEIM in IntelSiliconPkg in edk2-platforms. This patch doesn't provide a DXE version shadow microcode protocol, a platform which only uses DxeMpInitLib instance only supports PCD based microcode shadowing. A detailed design doc can be found here: https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20 the%202nd%20Microcode%20FV%20Flash%20Region.pdf [Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib. [Patch 2/2] MdePkg: Remove FIT table industry standard header file. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Liming Gao Siyuan Fu (2): UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib. MdePkg: Remove FIT table industry standard header file. .../IndustryStandard/FirmwareInterfaceTable.h | 76 ------------- UefiCpuPkg/Include/Ppi/ShadowMicrocode.h | 66 +++++++++++ UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 - UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 26 ++++- UefiCpuPkg/Library/MpInitLib/Microcode.c | 105 +----------------- UefiCpuPkg/Library/MpInitLib/MpLib.h | 19 +++- UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 4 +- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 68 ++++++++++++ UefiCpuPkg/UefiCpuPkg.dec | 11 +- UefiCpuPkg/UefiCpuPkg.uni | 6 - 10 files changed, 183 insertions(+), 199 deletions(-) delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h -- 2.19.1.windows.1