* [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib
@ 2020-07-21 7:28 IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:28 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
IanX Kuo (6):
Platform/Intel/MinPlatformPkg: Fix build error
Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib
.../CometlakeURvp/OpenBoardPkg.dsc | 4 ++-
.../GalagoPro3/OpenBoardPkg.dsc | 6 +++--
.../KabylakeRvp3/OpenBoardPkg.dsc | 6 +++--
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 1 +
.../Library/ReportCpuHobLib/ReportCpuHobLib.c | 3 ++-
.../ReportCpuHobLib/ReportCpuHobLib.inf | 2 +-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
.../BoardX58Ich10/OpenBoardPkg.dsc | 6 +++--
.../UpXtreme/OpenBoardPkg.dsc | 4 ++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 +++--
11 files changed, 30 insertions(+), 36 deletions(-)
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
@ 2020-07-21 7:29 ` IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:29 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
1. Fix ReportCpuHobLib build error
2. Change MODULE from BASE to PEIM
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 3 ++-
.../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
index aa2565343c..7eb29152f8 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
@@ -6,7 +6,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
**/
-#include <Base.h>
+#include <PiPei.h>
+#include <Library/BaseLib.h>
#include <Library/HobLib.h>
VOID
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
index a1830d4320..df1d780ece 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
@@ -12,7 +12,7 @@
BASE_NAME = ReportCpuHobLib
FILE_GUID = F19AA754-CE24-448D-B755-1F939B00C25D
VERSION_STRING = 1.0
- MODULE_TYPE = BASE
+ MODULE_TYPE = PEIM
LIBRARY_CLASS = ReportCpuHobLib
[LibraryClasses]
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
@ 2020-07-21 7:29 ` IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:29 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 136e530997..6a5c993b85 100644
@@ -172,6 +173,7 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 3/6] Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
@ 2020-07-21 7:29 ` IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:29 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 6 ++++--
.../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
index 6e35495aaf..54f10ff07c 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the GalagoPro3 board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -160,6 +161,7 @@
DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Platform Package
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
index 2a086cd9f7..bba3510cc6 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the KabylakeRvp3 board.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -212,6 +213,7 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 4/6] Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
` (2 preceding siblings ...)
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
@ 2020-07-21 7:30 ` IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:30 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 8a82600912..a2d35582e7 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the X58Ich10 board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -144,6 +145,7 @@
!endif
TestPointLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
[LibraryClasses.common.DXE_DRIVER]
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
` (3 preceding siblings ...)
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
@ 2020-07-21 7:30 ` IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:30 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 +++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 ++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index fdf85b4385..1e6bd7fd5a 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -172,6 +173,7 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
index 11dffb085a..502e015eb9 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the WhiskeylakeURvp board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -172,6 +173,7 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platforms] [PATCH v8 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
` (4 preceding siblings ...)
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
@ 2020-07-21 7:30 ` IanX Kuo
2020-07-21 9:11 ` [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib Liming Gao
2020-07-21 12:41 ` Chiu, Chasel
7 siblings, 0 replies; 9+ messages in thread
From: IanX Kuo @ 2020-07-21 7:30 UTC (permalink / raw)
To: devel
Cc: james.lu, chandana.c.kumar, varalakshmi.a.prabhala, liming.gao,
IanX Kuo, Sai Chaganty, Chasel Chiu
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overridden by Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 1 +
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
3 files changed, 5 insertions(+), 24 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 13a0fda272..112ddff7d9 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -92,6 +92,7 @@
#
FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
index efdeb6a91c..48cbe0dfbe 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
@@ -1,7 +1,7 @@
/** @file
Source code file for Platform Init Pre-Memory PEI module
-Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/BoardInitLib.h>
#include <Library/TestPointCheckLib.h>
#include <Library/SetCacheMtrrLib.h>
+#include <Library/ReportCpuHobLib.h>
#include <Guid/MemoryTypeInformation.h>
#include <Ppi/PlatformMemorySize.h>
#include <Ppi/BaseMemoryTest.h>
@@ -355,28 +356,6 @@ Done:
return EFI_SUCCESS;
}
-VOID
-ReportCpuHob (
- VOID
- )
-{
- UINT8 PhysicalAddressBits;
- UINT32 RegEax;
-
- AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL);
- if (RegEax >= 0x80000008) {
- AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL);
- PhysicalAddressBits = (UINT8) RegEax;
- } else {
- PhysicalAddressBits = 36;
- }
-
- ///
- /// Create a CPU hand-off information
- ///
- BuildCpuHob (PhysicalAddressBits, 16);
-}
-
/**
Install Firmware Volume Hob's once there is main memory
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index 7ee18eb6d5..8e828ff2ac 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -1,7 +1,7 @@
### @file
# Component information file for the Platform Init Pre-Memory PEI module.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -28,6 +28,7 @@
TestPointCheckLib
TimerLib
SetCacheMtrrLib
+ ReportCpuHobLib
[Packages]
MinPlatformPkg/MinPlatformPkg.dec
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
` (5 preceding siblings ...)
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
@ 2020-07-21 9:11 ` Liming Gao
2020-07-21 12:41 ` Chiu, Chasel
7 siblings, 0 replies; 9+ messages in thread
From: Liming Gao @ 2020-07-21 9:11 UTC (permalink / raw)
To: Kuo, IanX, devel@edk2.groups.io
Cc: Lu, James, Kumar, Chandana C, Prabhala, Varalakshmi A,
Chaganty, Rangasai V, Chiu, Chasel
This version is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Kuo, IanX <ianx.kuo@intel.com>
Sent: 2020年7月21日 15:29
To: devel@edk2.groups.io
Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A <varalakshmi.a.prabhala@intel.com>; Gao, Liming <liming.gao@intel.com>; Kuo, IanX <ianx.kuo@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib
Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.PA bits reported can be overridden by Library instance in Platform.Signed-off-by: IanX Kuo <ianx.kuo@intel.com>Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>Cc: Chasel Chiu <chasel.chiu@intel.com> IanX Kuo (6):
Platform/Intel/MinPlatformPkg: Fix build error
Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib
Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib
.../CometlakeURvp/OpenBoardPkg.dsc | 4 ++-
.../GalagoPro3/OpenBoardPkg.dsc | 6 +++--
.../KabylakeRvp3/OpenBoardPkg.dsc | 6 +++--
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 1 +
.../Library/ReportCpuHobLib/ReportCpuHobLib.c | 3 ++-
.../ReportCpuHobLib/ReportCpuHobLib.inf | 2 +-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
.../BoardX58Ich10/OpenBoardPkg.dsc | 6 +++--
.../UpXtreme/OpenBoardPkg.dsc | 4 ++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 +++--
11 files changed, 30 insertions(+), 36 deletions(-)
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
` (6 preceding siblings ...)
2020-07-21 9:11 ` [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib Liming Gao
@ 2020-07-21 12:41 ` Chiu, Chasel
7 siblings, 0 replies; 9+ messages in thread
From: Chiu, Chasel @ 2020-07-21 12:41 UTC (permalink / raw)
To: Kuo, IanX, devel@edk2.groups.io
Cc: Lu, James, Kumar, Chandana C, Prabhala, Varalakshmi A,
Gao, Liming, Chaganty, Rangasai V
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kuo, IanX <ianx.kuo@intel.com>
> Sent: Tuesday, July 21, 2020 3:29 PM
> To: devel@edk2.groups.io
> Cc: Lu, James <james.lu@intel.com>; Kumar, Chandana C
> <chandana.c.kumar@intel.com>; Prabhala, Varalakshmi A
> <varalakshmi.a.prabhala@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Kuo, IanX <ianx.kuo@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-platforms] [PATCH v8 0/6] Create a Library instance of
> ReportCpuHobLib
>
> Create a Library instance of ReportCpuHobLib from PlatformInitPei driver.PA
> bits reported can be overridden by Library instance in Platform.Signed-off-by:
> IanX Kuo <ianx.kuo@intel.com>Cc: Sai Chaganty
> <rangasai.v.chaganty@intel.com>Cc: Chasel Chiu <chasel.chiu@intel.com>
> IanX Kuo (6):
> Platform/Intel/MinPlatformPkg: Fix build error
> Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib
> Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib
> Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib
> Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib
> Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib
>
> .../CometlakeURvp/OpenBoardPkg.dsc | 4 ++-
> .../GalagoPro3/OpenBoardPkg.dsc | 6 +++--
> .../KabylakeRvp3/OpenBoardPkg.dsc | 6 +++--
> .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 1 +
> .../Library/ReportCpuHobLib/ReportCpuHobLib.c | 3 ++-
> .../ReportCpuHobLib/ReportCpuHobLib.inf | 2 +-
> .../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
> .../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
> .../BoardX58Ich10/OpenBoardPkg.dsc | 6 +++--
> .../UpXtreme/OpenBoardPkg.dsc | 4 ++-
> .../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 +++--
> 11 files changed, 30 insertions(+), 36 deletions(-)
>
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-21 12:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-21 7:28 [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
2020-07-21 7:29 ` [edk2-platforms] [PATCH v8 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
2020-07-21 7:30 ` [edk2-platforms] [PATCH v8 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
2020-07-21 9:11 ` [edk2-platforms] [PATCH v8 0/6] Create a Library instance of ReportCpuHobLib Liming Gao
2020-07-21 12:41 ` Chiu, Chasel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox