From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.45]) by mx.groups.io with SMTP id smtpd.web10.11091.1631289525453013848 for ; Fri, 10 Sep 2021 08:58:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=nf8tSzTY; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.212.45, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nL6M0a8tDVtAQTrXh1r6LPQYgxGuC1srxQfm/2aELCyKa6ooNMe1NqX7CAFkeL9QgIHicI0guY4Bp6HEffflEFJ3ILv6QtV1XOFRTdHm1RaPyvFVg98DfKXPSQPRr4HWKJOSFNgstbdmXOhg/leMwM8h8B0DYOUavtk6PgEdt/2X5hXtDGtZMhinU51UFl7nRT3TYwYl+IHcbua3DnkDOb7akwb4p1o+fJiQogj9puN+1+7Cg30Z+ObR1DMC50T/aqLIVa6NNB022mkrINAevfGHR2RXKGHcbDErXtaeRwn8UHp4FT+y2ySh5m73SQ/5EpNxq6kzQPXz10zsfFlrbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C6NvIQ3rhGXx2h5K3G4NoeV3+kzhAFEuudb2SKK0yYk=; b=eGxuFPHDZv0WFYa2zcRNa6EhK32EvtqphNLAS8jCPlHHHMZuEmqfQdInDnLDPqbczA3QaXpKoVlwnPii3qsA0ly/BLF3cBDpVHx/BgCybJ94rBZ9xiS+y6/N9P0HrGbbI4EnbPXPQ1CZ6uDkLFdT4CDxv5q+aKIrqPv4khQ5PaHQR2VF/1LYZLFEkSXgYCawihTRWHuwtX0YPpgOqeq4rdHaHbcre+d0r1bTEQFIGrhTmMxEh/RVAxIog3398nbQrGZqPA7BJ9zJUwvF+IP9JZPDf9Dl/OpqPjVKylNxSfIES0udUfdI9TxeQezsCe6VFa1BuogRPyXG2m7CUdbkrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6NvIQ3rhGXx2h5K3G4NoeV3+kzhAFEuudb2SKK0yYk=; b=nf8tSzTY4v5ntKCccwzAm57IZVLbzmh5z5VA8PDALZhtxZn/Nz9UZXAaFqbaa4Q+QOBeMP7Qz3wFC7HvapNkn97WdQBzXCWqfEo3C8DRbISmT/KPp8twhYe7QVLpHg+yd3siL9IKay2vVgy2XYB275ZtFiZQ+RZq8lCAQtxEX2NOzI6GlO+2ZHheoaKsj+Oxw/ZNtAQNBKFNnZU8Jr7IJ/tNouPnFsF6gANLXOnmw65suKkqLu9nLYPTOsPhNn/R2q3nKqPTWf8gcRr8q53aFvKOz7E7bz6cMZM4nkXN+uq+gE+pop/3NNhftYGHDtgjhRT+aEPJI2LuJNYRHgJYhw== Received: from BN6PR13CA0032.namprd13.prod.outlook.com (2603:10b6:404:13e::18) by DM6PR12MB3402.namprd12.prod.outlook.com (2603:10b6:5:3b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Fri, 10 Sep 2021 15:58:43 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:404:13e:cafe::36) by BN6PR13CA0032.outlook.office365.com (2603:10b6:404:13e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.9 via Frontend Transport; Fri, 10 Sep 2021 15:58:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4500.14 via Frontend Transport; Fri, 10 Sep 2021 15:58:43 +0000 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 10 Sep 2021 08:58:41 -0700 Received: from build-jbrasen-20210819T103534360.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.10) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Fri, 10 Sep 2021 15:58:41 +0000 From: "Jeff Brasen" To: CC: , Jeff Brasen Subject: [PATCH v2 0/2] ExtPkg Updates Date: Fri, 10 Sep 2021 15:58:37 +0000 Message-ID: X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: jbrasen@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 475ac611-19f5-45da-0d28-08d97473dd6a X-MS-TrafficTypeDiagnostic: DM6PR12MB3402: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e42Ze+5TcsHiHDE2HCYuJs96gftuuVBYVTYaLze5fWz8XMSpvOMddrymvOaNqEyRCBcBr0UMQgd0FXGdFWjFBzaPbhUH8TWpr/K0LMTc0Dvskf/2ugKx3CcVXIp+e1FI8qDg+eIr3845C6oyQDfn1AH2KNgjeJ8WzBbM5d6hFEq+Y8+pKaN/hAbqJA54DlmwWM9eHnD8EC8Z2zCkYkt1RCfkTUrGholWS4Q8aMke++zBJpN1atlfs3vMeEyXyEjBrmjkacsrePyzr398+0dezxsXlFL6qOCWZFpGUQ150QRcUt+rpBmvIQPE7BZZ3yIgDCwRyrHya9GmvoiehKCLhxAJ/3XOVq8Zh0kbKggyZ9dYc6nYIyvrQAoQqKF++O5LKv32SocFHvExRray0b2zfZYShGPkrjNz7yFCmxKQhzqgwzC6/5mZYENfoZCe2A8y7BESLxkFlYx9Oh1J785Zjd3WedWuUdkDMyXmrdVrpqCi1QtNacpt2K1tjvsNQ4EghsMq0o7ZPbx3TqWAAWyPwB4f1vh0xIuVSDY94gy3E8GKQYUdIBwXWIou0DFUFfeIKuMKGCpuqA2Gp5ChNWj09JdRucNo0P5Z9h13BMmlRFJ49Xzxid9zzkRnXUFxO9tVCMuAcRcb4QFZwlf2bcEABQenlpqJZYYQeX4c1yKqeA05smJCorDeLwdImHkrKLsLYTIOpYomp9B+hQBK5HPqGg== X-Forefront-Antispam-Report: CIP:216.228.112.32;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid01.nvidia.com;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(36840700001)(46966006)(5660300002)(2906002)(15650500001)(2616005)(54906003)(36860700001)(82310400003)(7696005)(4326008)(47076005)(478600001)(86362001)(316002)(336012)(426003)(83380400001)(356005)(7636003)(6666004)(6916009)(70206006)(70586007)(8936002)(107886003)(26005)(8676002)(36756003)(19627235002)(186003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 15:58:43.2722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 475ac611-19f5-45da-0d28-08d97473dd6a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.32];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3402 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain I have been using the new Ext4Pkg and been pretty successful and it is solv= ing a use case we had. Had a couple updates to propose 1. Changed the implementation of the binding protocol to both check if the = driver is already bound to the partition as well as added a really quick check to validate the magi= c value in supported. This improves performance when you have a large number of non-ext4 partitio= ns on the system. 2. As we are planning on using this for boot support we want to support unc= lean filesystem states in case the user doesn't reset cleanly. I added a check if the recovery journa= l is present and if so treat the filesystem as read-only (I know the driver is only RO at this point, bu= t figured if you added write support prior to recovery journal support we would want that). With this ev= erything seems to work great. I can add this under a FeaturePcd if desired as well. Change log v2 - Minor code review comments v1 - Initial revision Jeff Brasen (2): Ext4Pkg: Improve Ext4IsBindingSupported() behavior Ext4Pkg: Support uncleanly unmounted filesystems Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 14 +++++++ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 58 +++++++++++++++++++++------ Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++-- 3 files changed, 102 insertions(+), 16 deletions(-) --=20 2.17.1