From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.67]) by mx.groups.io with SMTP id smtpd.web08.44.1631311892958783008 for ; Fri, 10 Sep 2021 15:11:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=pYwtCPY2; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.67, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kTYwLjHfRIu6wECsfeWqTKrXccLQ6ewS1PYCbmuS1eIEFx9aCKoG5neXI4sHMxBHqjKYpm/IDMvuAEGVhLLwqyimpcIvDBbnlXcBqLgAaDnIpLo+nuGbT8AChG+zt6DzO2KYeLmaLq4jrWjojCpvvwmhyNkZMwqdmc+zx9YnmZDEgUnAfWcZXs4IJ1r4l5muPAkZlZN1kQaOmw/vmQR263kDY5x+wkvp836AVg8V2dkXyJXCLhdQ+OmJPb5NKdf5fcL8izQ89PhZgkxgSR7+kQA5sgiMgpNFeyQdZKlXtl/Dao9kT0iLlylQUIEFHOBmNSjSd+qUcba/CEpqO1DsKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3Dui4s0O27x8l9xA/oSSx/MZvMXNeARn1ZXltWLOwA=; b=SL8jgSoyLdl8sDNghL87MbnjdO3IiFczQhlvutrwqssAdrEEVgH67yjiY05YwCKGtNA6F1gkKGemK9K2+2yYwAugIUB3ht3yVwdrREBuL3zAZGrsqN5P908EHBeYCjKNc1/7Q8kAV6G1sacymM3zKn0QoT1B3B4vMqdGNDPDCSg3sqLmewnj05Pd01mvkXO/6KC3awtIS1cuf+JLgfJxQNu+V4OZotAmt5ssKzUbipYCursUgtJoV0tONezmTO1Ad6zpmOB1Zgq49/rwxLshh1EJh/cJBIil9soHD32UEE5NTUw3tpBrxS1yE6M0/lQFYuzRHKuhkARkxyEQewclOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3Dui4s0O27x8l9xA/oSSx/MZvMXNeARn1ZXltWLOwA=; b=pYwtCPY2NF4FQXdMuy7mfpB/UYWRHjl4AMBcaXgRnF+GIraYZPFSwGL3YHwDIjw2K9+5vJB8b28D5nqQD57T506yi370TS6NPCR29cmAGCfckEnAarn9TH3Bb1sSQoPQ8bxRUfSEdKUuHhrhLDnjfBYNJ533g9F7b9B+0I3VZZtb0PKyFY1s9u0fbHKZw0r16Hfd0rmdVWGMsAgDtAHIPKo4g8qPCYTcpW4D+B0+OjZV4wwdMZxrZh12v3CnMbw/HiwgA1xIhL79aJCTPqLbKuj4Ih8Wq21qV8oVrwCfAhOV3Y5OaHSqMzn8HfMAg4U1T1ha9K8gLNZDgBxVhNocNQ== Received: from BN8PR04CA0014.namprd04.prod.outlook.com (2603:10b6:408:70::27) by BN9PR12MB5356.namprd12.prod.outlook.com (2603:10b6:408:105::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Fri, 10 Sep 2021 22:11:31 +0000 Received: from BN8NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::db) by BN8PR04CA0014.outlook.office365.com (2603:10b6:408:70::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Fri, 10 Sep 2021 22:11:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by BN8NAM11FT060.mail.protection.outlook.com (10.13.177.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4500.14 via Frontend Transport; Fri, 10 Sep 2021 22:11:31 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 10 Sep 2021 22:11:30 +0000 Received: from build-jbrasen-20210819T103534360.nvidia.com (172.20.187.5) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Fri, 10 Sep 2021 15:11:30 -0700 From: "Jeff Brasen" To: CC: , Jeff Brasen Subject: [PATCH v3 0/2] ExtPkg Updates Date: Fri, 10 Sep 2021 22:11:26 +0000 Message-ID: X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: jbrasen@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a529ad50-ebd6-464f-9864-08d974a7f1e9 X-MS-TrafficTypeDiagnostic: BN9PR12MB5356: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HhWq237IqGvFP+1QvdvzIEBTdK8O/ZS9hG5Dsik+OxaEV5Hy+wSc5EYR52NXojIimiugn63403KEXr2iPjMldXomYyqo5AW6fH03L9W3Aql1bMxjYIadpj4tudkHVEpkUxK1lt/R4u9NNUMJXfOGugXGkx10yNVa05XHliqegjVMSJGwkbt5WUF//+Ra1jvURmVwyELnWVs6sJBBn3fDIPwBPs/6XzBblULY5qgroFs6syAQODR8FxKq2PvKCQKmIXNGkJHS3A2I40iXWj73pzplmhchjuMWWiGef/ctVvGBAxw0Rb9y+BnBrInrMy6DjAime/zBKaRDb1KGYRYGOcnwJAOR2qHQY+dmk3an5FtognaicdHnFBiu0iziUv1TQAxCvqd0rkwRtgcNmHPRzJK6psBayHoxrbfAeLydhW2rX86ynUrXdFd0wVYIV4TqbdxiVarGP8rv8Yx8mWCgtokRoGSIYRRVrWfhfWwfeUKlMBE5DzXasrJuR0bqfIAZxzovQzRp0TJ1Z8cP/20Rp6kAU2OwsGCygn6oaFuciuxNTQJcv4K3rMJWA51s+IW9fO/b/Qyyuuc40GCgT5bKSEM8Yo/N+Z3MbKGw9nQRgEk6KHUcMSjOCFKoOyLkklj9IhXpVbD5tVCLalt+3JMdNvgW+EeCUJ0MDn3/4GHNoPLES/N8whlb6K0mZwWOim1CtrP6ADy4Zh88xciuPTN+cQ== X-Forefront-Antispam-Report: CIP:216.228.112.36;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid05.nvidia.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(36840700001)(46966006)(83380400001)(107886003)(8676002)(26005)(86362001)(8936002)(426003)(70206006)(316002)(5660300002)(336012)(478600001)(2906002)(36860700001)(54906003)(6666004)(47076005)(7636003)(15650500001)(19627235002)(36906005)(6916009)(186003)(7696005)(70586007)(36756003)(82310400003)(2616005)(82740400003)(356005)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 22:11:31.4915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a529ad50-ebd6-464f-9864-08d974a7f1e9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.36];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5356 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain I have been using the new Ext4Pkg and been pretty successful and it is solv= ing a use case we had. Had a couple updates to propose 1. Changed the implementation of the binding protocol to both check if the = driver is already bound to the partition as well as added a really quick check to validate the magi= c value in supported. This improves performance when you have a large number of non-ext4 partitio= ns on the system. 2. As we are planning on using this for boot support we want to support unc= lean filesystem states in case the user doesn't reset cleanly. I added a check if the recovery journa= l is present and if so treat the filesystem as read-only (I know the driver is only RO at this point, bu= t figured if you added write support prior to recovery journal support we would want that). With this ev= erything seems to work great. I can add this under a FeaturePcd if desired as well. Change log v3 - Removed goto flow on binding supported failures Minor code review comments v2 - Minor code review comments v1 - Initial revision Jeff Brasen (2): Ext4Pkg: Improve Ext4IsBindingSupported() behavior Ext4Pkg: Support uncleanly unmounted filesystems Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 14 +++++++ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 54 +++++++++++++++++++++------ Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++-- 3 files changed, 99 insertions(+), 15 deletions(-) --=20 2.17.1