public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: devel@edk2.groups.io
Cc: Min Xu <min.m.xu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: [PATCH 00/14] Introduce PlatformInitLib in OvmfPkg
Date: Tue,  8 Mar 2022 10:36:01 +0800	[thread overview]
Message-ID: <cover.1646706302.git.min.m.xu@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863

There are 3 variants of PlatformPei in OvmfPkg:
 - OvmfPkg/PlatformPei
 - OvmfPkg/Bhyve/PlatformPei
 - OvmfPkg/XenPlatformPei

A lot of common code can be shared in above PlatformPeis. Further more,
with the upstreaming of TDVF (Pei-less boot mode), a library which
wraps the common functions is needed. PlatformInitLib is designed
to meet this requirement.

PlatformInitLib is designed to run in both PEI and SEC. So global
variables and dynamic PCDs are avoided.

As the first stage, OvmfPkg/PlatformPei will be refactored with
PlatformInitLib. In the future we will refactor other PlatformPeis
with this lib as well.

Patch 1 - 2: 
Create initial version of PlatformInitLib and move Cmos / Hob functions
to the lib.

Patch 3:
Move global variables in PlatformPei to PlatformInfoHob. Changes are
all in OvmfPkg/PlatformPei.

Patch 4 - 12:
These patches restruct the functions which set PCDs into two, one for
PlatformInitLib, one for PlatformPei.

Patch 13 - 14:
Pure move from PlatformPei to PlatformInitLib.

Code at: https://github.com/mxu9/edk2/tree/platform-init-lib-v1

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>

Min Xu (14):
  OvmfPkg: Create initial version of PlatformInitLib
  OvmfPkg/PlatformInitLib: Add hob functions
  OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob
  OvmfPkg/PlatformPei: Refactor MiscInitialization
  OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV
  OvmfPkg/PlatformPei: Refactor AddressWidthInitialization
  OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization
  OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization
  OvmfPkg/PlatformPei: Refactor InitializeRamRegions
  OvmfPkg/PlatformPei: Refactor MemMapInitialization
  OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization
  OvmfPkg/PlatformPei: Refactor MiscInitialization
  OvmfPkg/PlatformInitLib: Create MemDetect.c
  OvmfPkg/PlatformInitLib: Move functions to Platform.c

 OvmfPkg/AmdSev/AmdSevX64.dsc                  |   1 +
 OvmfPkg/CloudHv/CloudHvX64.dsc                |   1 +
 OvmfPkg/Include/Library/PlatformInitLib.h     | 206 +++++
 .../PlatformInitLib}/Cmos.c                   |  32 +-
 OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 842 +++++++++++++++++
 OvmfPkg/Library/PlatformInitLib/Platform.c    | 571 ++++++++++++
 .../PlatformInitLib/PlatformInitLib.inf       |  87 ++
 OvmfPkg/Microvm/MicrovmX64.dsc                |   1 +
 OvmfPkg/OvmfPkg.dec                           |   4 +
 OvmfPkg/OvmfPkgIa32.dsc                       |   1 +
 OvmfPkg/OvmfPkgIa32X64.dsc                    |   1 +
 OvmfPkg/OvmfPkgX64.dsc                        |   1 +
 OvmfPkg/PlatformPei/AmdSev.c                  |  10 +-
 OvmfPkg/PlatformPei/Cmos.h                    |  48 -
 OvmfPkg/PlatformPei/Fv.c                      |   6 +-
 OvmfPkg/PlatformPei/MemDetect.c               | 874 ++----------------
 OvmfPkg/PlatformPei/MemTypeInfo.c             |   4 +-
 OvmfPkg/PlatformPei/Platform.c                | 616 ++----------
 OvmfPkg/PlatformPei/Platform.h                |  80 +-
 OvmfPkg/PlatformPei/PlatformPei.inf           |   3 +-
 20 files changed, 1912 insertions(+), 1477 deletions(-)
 create mode 100644 OvmfPkg/Include/Library/PlatformInitLib.h
 rename OvmfPkg/{PlatformPei => Library/PlatformInitLib}/Cmos.c (61%)
 create mode 100644 OvmfPkg/Library/PlatformInitLib/MemDetect.c
 create mode 100644 OvmfPkg/Library/PlatformInitLib/Platform.c
 create mode 100644 OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf
 delete mode 100644 OvmfPkg/PlatformPei/Cmos.h

-- 
2.29.2.windows.2


             reply	other threads:[~2022-03-08  2:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  2:36 Min Xu [this message]
2022-03-08  2:36 ` [PATCH 01/14] OvmfPkg: Create initial version of PlatformInitLib Min Xu
2022-03-08  2:36 ` [PATCH 02/14] OvmfPkg/PlatformInitLib: Add hob functions Min Xu
2022-03-08  2:36 ` [PATCH 03/14] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob Min Xu
2022-03-08  2:36 ` [PATCH 04/14] OvmfPkg/PlatformPei: Refactor MiscInitialization Min Xu
2022-03-08  2:36 ` [PATCH 05/14] OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV Min Xu
2022-03-08  2:36 ` [PATCH 06/14] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Min Xu
2022-03-08  2:36 ` [PATCH 07/14] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization Min Xu
2022-03-08  2:36 ` [PATCH 08/14] OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization Min Xu
2022-03-08  2:36 ` [PATCH 09/14] OvmfPkg/PlatformPei: Refactor InitializeRamRegions Min Xu
2022-03-08  2:36 ` [PATCH 10/14] OvmfPkg/PlatformPei: Refactor MemMapInitialization Min Xu
2022-03-08  2:36 ` [PATCH 11/14] OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization Min Xu
2022-03-08  2:36 ` [PATCH 12/14] OvmfPkg/PlatformPei: Refactor MiscInitialization Min Xu
2022-03-08  2:36 ` [PATCH 13/14] OvmfPkg/PlatformInitLib: Create MemDetect.c Min Xu
2022-03-08  2:36 ` [PATCH 14/14] OvmfPkg/PlatformInitLib: Move functions to Platform.c Min Xu
2022-03-08  9:50 ` [PATCH 00/14] Introduce PlatformInitLib in OvmfPkg Boeuf, Sebastien
2022-03-09 12:24 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1646706302.git.min.m.xu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox