From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.4209.1646706992182166839 for ; Mon, 07 Mar 2022 18:36:32 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ktZ3dKL9; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646706992; x=1678242992; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=dW0aodR+AB+7wuhG0gXH2T60s04qdgN/jYaQjrF1MoQ=; b=ktZ3dKL9+K4GShhBITtn3031cDAxvP74ukl0iXRPgAnOX5X7cHLDcUFi Z+2QxlnItAy0HOXrYoClY5D/8V/ulC+SqI+fG03I6cmjNgDXHtwhpZB7K 2LOHj1NjNqF2E5LjsbkZitmdaDPbTFWvHDe7gTz49rXSR8+92ViRlElvy IpUVOt5vDWy+Bx5UutxsV7miW6hMXdzEI9YvZwC6NdDs5oPkDOCZFVR7N tcc86pvgZluSywdFRmBKX8v7v3/ZTLGsXhsLpr20V8h62HhnSMif7hW41 +LQtvMSiWFrSNpBhMS/cSVch02ZBU7qcT9Q07E4uSgFpM8inLaWWR1NhG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="317800921" X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="317800921" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 18:36:31 -0800 X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="553432572" Received: from mxu9-mobl1.ccr.corp.intel.com ([10.238.2.184]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 18:36:28 -0800 From: "Min Xu" To: devel@edk2.groups.io Cc: Min Xu , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Gerd Hoffmann , Sebastien Boeuf Subject: [PATCH 00/14] Introduce PlatformInitLib in OvmfPkg Date: Tue, 8 Mar 2022 10:36:01 +0800 Message-Id: X-Mailer: git-send-email 2.29.2.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 There are 3 variants of PlatformPei in OvmfPkg: - OvmfPkg/PlatformPei - OvmfPkg/Bhyve/PlatformPei - OvmfPkg/XenPlatformPei A lot of common code can be shared in above PlatformPeis. Further more, with the upstreaming of TDVF (Pei-less boot mode), a library which wraps the common functions is needed. PlatformInitLib is designed to meet this requirement. PlatformInitLib is designed to run in both PEI and SEC. So global variables and dynamic PCDs are avoided. As the first stage, OvmfPkg/PlatformPei will be refactored with PlatformInitLib. In the future we will refactor other PlatformPeis with this lib as well. Patch 1 - 2: Create initial version of PlatformInitLib and move Cmos / Hob functions to the lib. Patch 3: Move global variables in PlatformPei to PlatformInfoHob. Changes are all in OvmfPkg/PlatformPei. Patch 4 - 12: These patches restruct the functions which set PCDs into two, one for PlatformInitLib, one for PlatformPei. Patch 13 - 14: Pure move from PlatformPei to PlatformInitLib. Code at: https://github.com/mxu9/edk2/tree/platform-init-lib-v1 Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Cc: Sebastien Boeuf Signed-off-by: Min Xu Min Xu (14): OvmfPkg: Create initial version of PlatformInitLib OvmfPkg/PlatformInitLib: Add hob functions OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob OvmfPkg/PlatformPei: Refactor MiscInitialization OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV OvmfPkg/PlatformPei: Refactor AddressWidthInitialization OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization OvmfPkg/PlatformPei: Refactor InitializeRamRegions OvmfPkg/PlatformPei: Refactor MemMapInitialization OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization OvmfPkg/PlatformPei: Refactor MiscInitialization OvmfPkg/PlatformInitLib: Create MemDetect.c OvmfPkg/PlatformInitLib: Move functions to Platform.c OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + OvmfPkg/Include/Library/PlatformInitLib.h | 206 +++++ .../PlatformInitLib}/Cmos.c | 32 +- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 842 +++++++++++++++++ OvmfPkg/Library/PlatformInitLib/Platform.c | 571 ++++++++++++ .../PlatformInitLib/PlatformInitLib.inf | 87 ++ OvmfPkg/Microvm/MicrovmX64.dsc | 1 + OvmfPkg/OvmfPkg.dec | 4 + OvmfPkg/OvmfPkgIa32.dsc | 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/PlatformPei/AmdSev.c | 10 +- OvmfPkg/PlatformPei/Cmos.h | 48 - OvmfPkg/PlatformPei/Fv.c | 6 +- OvmfPkg/PlatformPei/MemDetect.c | 874 ++---------------- OvmfPkg/PlatformPei/MemTypeInfo.c | 4 +- OvmfPkg/PlatformPei/Platform.c | 616 ++---------- OvmfPkg/PlatformPei/Platform.h | 80 +- OvmfPkg/PlatformPei/PlatformPei.inf | 3 +- 20 files changed, 1912 insertions(+), 1477 deletions(-) create mode 100644 OvmfPkg/Include/Library/PlatformInitLib.h rename OvmfPkg/{PlatformPei => Library/PlatformInitLib}/Cmos.c (61%) create mode 100644 OvmfPkg/Library/PlatformInitLib/MemDetect.c create mode 100644 OvmfPkg/Library/PlatformInitLib/Platform.c create mode 100644 OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf delete mode 100644 OvmfPkg/PlatformPei/Cmos.h -- 2.29.2.windows.2