public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 0/2] Include HardwareInfoLib in all platforms using
@ 2022-06-23 15:22 Ojeda Leon, Nicolas
  2022-06-23 15:23 ` [PATCH 1/2] ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc Ojeda Leon, Nicolas
  2022-06-24 18:07 ` [PATCH 0/2] Include HardwareInfoLib in all platforms using Ard Biesheuvel
  0 siblings, 2 replies; 3+ messages in thread
From: Ojeda Leon, Nicolas @ 2022-06-23 15:22 UTC (permalink / raw)
  To: devel
  Cc: graf, quic_llindhol, sami.mujawar, brijesh.singh, erdemaktas,
	jejb, min.m.xu, thomas.lendacky, rebecca, grehan, sebastien.boeuf,
	anthony.perard, julien, ardb+tianocore, jiewen.yao,
	jordan.l.justen, kraxel, Nicolas Ojeda Leon

In past days, a patch series to support multiple PCI host bridges in Ovmf
was merged which caused an error in ArmVirtQemuKernel.dsc build, part
of the CI pipeline.

These 2 commits aim at fixing this issue by adding the HardwareInfoLib
to all ArmVirt* platofrms as well as for IntelTdx which were missing
this library that now is a dependency of PciHostBridgeUtilityLib.

Nicolas Ojeda Leon (2):
  ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc
  Ovmf: Include HardwareInfoLib library classes for IntelTdx

 ArmVirtPkg/ArmVirt.dsc.inc       | 1 +
 ArmVirtPkg/ArmVirtQemu.dsc       | 1 -
 OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 ++
 3 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc
  2022-06-23 15:22 [PATCH 0/2] Include HardwareInfoLib in all platforms using Ojeda Leon, Nicolas
@ 2022-06-23 15:23 ` Ojeda Leon, Nicolas
  2022-06-24 18:07 ` [PATCH 0/2] Include HardwareInfoLib in all platforms using Ard Biesheuvel
  1 sibling, 0 replies; 3+ messages in thread
From: Ojeda Leon, Nicolas @ 2022-06-23 15:23 UTC (permalink / raw)
  To: devel
  Cc: graf, quic_llindhol, sami.mujawar, brijesh.singh, erdemaktas,
	jejb, min.m.xu, thomas.lendacky, rebecca, grehan, sebastien.boeuf,
	anthony.perard, julien, ardb+tianocore, jiewen.yao,
	jordan.l.justen, kraxel, Nicolas Ojeda Leon, Alexander Graf,
	Ard Biesheuvel

Include DxeHardwareInfoLib class in the common ArmVirt.dsc.inc so that
ArmVirt* platforms use it during build given that PciHostBridgeUtilityLib
depends on it.

Cc: Alexander Graf <graf@amazon.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Nicolas Ojeda Leon <ncoleon@amazon.com>
---
 ArmVirtPkg/ArmVirt.dsc.inc | 1 +
 ArmVirtPkg/ArmVirtQemu.dsc | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index f15a3f7f06..4732bd76d6 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -144,6 +144,7 @@
   PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf
   PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
   PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
+  DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf
 
   # USB Libraries
   UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 56eb53911d..9369a88858 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -82,7 +82,6 @@
   PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
   PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
   PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.inf
-  DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.inf
 
 !if $(TPM2_ENABLE) == TRUE
   Tpm2CommandLib|SecurityPkg/Library/Tpm2CommandLib/Tpm2CommandLib.inf
-- 
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/2] Include HardwareInfoLib in all platforms using
  2022-06-23 15:22 [PATCH 0/2] Include HardwareInfoLib in all platforms using Ojeda Leon, Nicolas
  2022-06-23 15:23 ` [PATCH 1/2] ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc Ojeda Leon, Nicolas
@ 2022-06-24 18:07 ` Ard Biesheuvel
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2022-06-24 18:07 UTC (permalink / raw)
  To: Nicolas Ojeda Leon
  Cc: edk2-devel-groups-io, Alexander Graf, Leif Lindholm, Sami Mujawar,
	Brijesh Singh, Erdem Aktas, James Bottomley, Min Xu, Tom Lendacky,
	Rebecca Cran, Peter Grehan, Sebastien Boeuf, Anthony Perard,
	Julien Grall, Ard Biesheuvel, Jiewen Yao, Jordan Justen,
	Gerd Hoffmann

On Thu, 23 Jun 2022 at 17:23, Nicolas Ojeda Leon <ncoleon@amazon.com> wrote:
>
> In past days, a patch series to support multiple PCI host bridges in Ovmf
> was merged which caused an error in ArmVirtQemuKernel.dsc build, part
> of the CI pipeline.
>
> These 2 commits aim at fixing this issue by adding the HardwareInfoLib
> to all ArmVirt* platofrms as well as for IntelTdx which were missing
> this library that now is a dependency of PciHostBridgeUtilityLib.
>
> Nicolas Ojeda Leon (2):
>   ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc
>   Ovmf: Include HardwareInfoLib library classes for IntelTdx
>

Thanks for the fixes

Merged as #3012

>  ArmVirtPkg/ArmVirt.dsc.inc       | 1 +
>  ArmVirtPkg/ArmVirtQemu.dsc       | 1 -
>  OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 ++
>  3 files changed, 3 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
>
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
> Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
> Sitz: Berlin
> Ust-ID: DE 289 237 879
>
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-24 18:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 15:22 [PATCH 0/2] Include HardwareInfoLib in all platforms using Ojeda Leon, Nicolas
2022-06-23 15:23 ` [PATCH 1/2] ArmVirtPkg: Include DxeHardwareInfoLib library class in dsc Ojeda Leon, Nicolas
2022-06-24 18:07 ` [PATCH 0/2] Include HardwareInfoLib in all platforms using Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox