From: "Oram, Isaac W" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Eric Dong <eric.dong@intel.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>,
Heng Luo <heng.luo@intel.com>,
Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>,
Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting
Date: Fri, 22 Jul 2022 11:46:11 -0700 [thread overview]
Message-ID: <cover.1658513099.git.isaac.w.oram@intel.com> (raw)
These changes simplify the logic for board porting by creating common include files for initializing PCD and for
some stage specific logic commonly implemented.
Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only.
Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure.
Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disable handler profiling on RELEASE builds.
The net result is removal of unnecessary or duplicate options and the reduction in duplicate code with increases
in comments.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Isaac Oram (13):
MinPlatformPkg/Include: Simplify board creation
WhitleyOpenBoardPkg/Build: Reduce duplicate code
Features/Intel: Reduce duplicate code
WhitleyOpenBoardPkg/Build: Reduce unnecessary code
MinPlatformPkg/Include: Simplify build logic
BoardModulePkg/Include: Add include for stage behavior logic
WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code
TigerLakeOpenBoardPkg/Build: Reduce unnecessary code
SimicsOpenBoardPkg/Build: Reduce unnecessary code
PurleyOpenBoardPkg/Build: Reduce unnecessary code
KabylakeOpenBoardPkg/Build: Reduce unnecessary code
CometlakeOpenBoardPkg/Build: Reduce unnecessary code
MinPlatformPkg: Remove unnecessary feature controls
.../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++--
.../AcpiDebugFeaturePkg.dsc | 12 ++--
.../BeepDebugFeaturePkg.dsc | 15 ++--
.../PostCodeDebugFeaturePkg.dsc | 15 ++--
.../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++--
.../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++--
.../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++--
.../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++--
.../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++--
.../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++--
.../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++--
.../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++--
.../VirtualKeyboardFeaturePkg.dsc | 13 ++--
.../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++++++++++
.../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 ++++---------
.../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 ++++----------
.../GalagoPro3/OpenBoardPkgPcd.dsc | 51 ++++---------
.../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 ++++---------
.../Include/Dsc/CoreCommonLib.dsc | 6 +-
.../Include/Dsc/CoreDxeInclude.dsc | 23 +++---
.../Dsc/MinPlatformFeaturesPcd.dsc.inc | 25 +++++++
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 -
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++--
.../BoardMtOlympus/PlatformPkgConfig.dsc | 46 ++++--------
.../BoardMtOlympus/PlatformPkgPcd.dsc | 52 ++++----------
.../BoardTiogaPass/PlatformPkgConfig.dsc | 48 ++++---------
.../BoardTiogaPass/PlatformPkgPcd.dsc | 52 ++++----------
.../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 ++++---------
.../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 ++++----------
.../UpXtreme/OpenBoardPkgPcd.dsc | 51 ++++---------
.../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 ++++---------
.../Aowanda/PlatformPkg.dsc | 3 -
.../BoardPortTemplate/PlatformPkg.dsc | 50 +++++++++++++
...blePerformanceMonitoringInfrastructure.dsc | 5 +-
...anceMonitoringInfrastructurePostMemory.fdf | 5 +-
...manceMonitoringInfrastructurePreMemory.fdf | 2 +-
.../JunctionCity/PlatformPkg.dsc | 3 -
.../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++++++-------------
.../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 -
39 files changed, 382 insertions(+), 645 deletions(-)
create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc
create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
--
2.36.1.windows.1
next reply other threads:[~2022-07-22 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 18:46 Oram, Isaac W [this message]
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 01/13] MinPlatformPkg/Include: Simplify board creation Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 02/13] WhitleyOpenBoardPkg/Build: Reduce duplicate code Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 03/13] Features/Intel: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 04/13] WhitleyOpenBoardPkg/Build: Reduce unnecessary code Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 05/13] MinPlatformPkg/Include: Simplify build logic Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 06/13] BoardModulePkg/Include: Add include for stage behavior logic Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 07/13] WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 08/13] TigerLakeOpenBoardPkg/Build: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 09/13] SimicsOpenBoardPkg/Build: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 10/13] PurleyOpenBoardPkg/Build: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 11/13] KabylakeOpenBoardPkg/Build: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 12/13] CometlakeOpenBoardPkg/Build: " Oram, Isaac W
2022-07-22 18:46 ` [edk2-devel][edk2-platforms][PATCH V1 13/13] MinPlatformPkg: Remove unnecessary feature controls Oram, Isaac W
2022-09-01 0:55 ` [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Nate DeSimone
2022-09-01 1:48 ` Isaac Oram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1658513099.git.isaac.w.oram@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox