From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DXSZNc+s; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658515598; x=1690051598; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nu0hefrWO5ojijiqwk/5LmzEhln7GAuRyd755U1FE2s=; b=DXSZNc+s/O8qlcRQe/CTdAJwueTy/j0eQ7tpo1Ze2X/9Gk5nEuhfbnm/ dTokoXRFWXuOF0haYiICcEW5zgWSBDtt+lzaCrinT8DM6YepJYJAtgwFJ TiVyZiPnyBnYFTEq+bfvVnb4cGrgM83LmPrq5OmSrpj4toDV+rPO2hZyk EIqN9GoEpzRZ1pzXmVow/QYQ9S40G7yxO3ExacIYH4gBxCRRQywAQK0pF WyutPX1QvrsyMbNGq89ts9VQ9MdiJSpSMlB+cfppR1bftSP+0beK7kZaP bNBFGvgEyb/lYgeFZ+NUklM4AOwr0YUpSzKlf8KksH40Gf86JN+SjuoXk A==; X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138256" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138256" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767952" Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:36 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong , Sai Chaganty , Heng Luo , Deepika Kethi Reddy , Kathappan Esakkithevar Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Date: Fri, 22 Jul 2022 11:46:11 -0700 Message-Id: X-Mailer: git-send-email 2.36.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These changes simplify the logic for board porting by creating common include files for initializing PCD and for some stage specific logic commonly implemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disable handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduction in duplicate code with increases in comments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Sai Chaganty Cc: Heng Luo Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++++++++++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 ++++---------- .../GalagoPro3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc | 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 25 +++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 ++++-------- .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 ++++--------- .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 ++++--------- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 ++++---------- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 ++++--------- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 +++++++++++++ ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringInfrastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemory.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++++++------------- .../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc -- 2.36.1.windows.1