public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abdul Lateef Attar" <abdattar@amd.com>
To: <devel@edk2.groups.io>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
	Oram Isaac W <isaac.w.oram@intel.com>,
	Eric Dong <eric.dong@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
Date: Wed, 18 Jan 2023 18:34:11 +0530	[thread overview]
Message-ID: <cover.1674045985.git.AbdulLateef.Attar@amd.com> (raw)

From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

PR : https://github.com/tianocore/edk2-platforms/pull/55/

V3 delta changes:
Addressed below review comments from Isaac
Patch 1:
  Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
  Line 168: Don't we need to free buffer on this path?
  Lines 655, 1083:  Please put a newline between while and the block to free resources.
DONE

Patch 2:
  edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c 338:
  Can you change to mUefiShellFileGuid and initialize it to zero?
  It seems misleading to me to have the default value here when it is not used.
  I think we should also move the declarations to the beginning of the file.
DONE

Cc: Oram Isaac W <isaac.w.oram@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Abdul Lateef Attar (2):
  BoardModulePkg: Copy device path before processing
  BoardModulePkg: Adds PCD to load UEFI Shell image

 .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++----
 .../BoardBdsHookLib/BoardBdsHookLib.inf       |  3 ++
 .../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++----------
 .../Intel/MinPlatformPkg/MinPlatformPkg.dec   |  5 ++++
 4 files changed, 41 insertions(+), 20 deletions(-)

-- 
2.25.1


             reply	other threads:[~2023-01-18 13:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 13:04 Abdul Lateef Attar [this message]
2023-01-19  0:30 ` [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Isaac Oram
     [not found] ` <173B8E643ABE185D.14781@groups.io>
2023-01-19  0:36   ` Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1674045985.git.AbdulLateef.Attar@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox