From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.47]) by mx.groups.io with SMTP id smtpd.web11.14556.1674047061577254105 for ; Wed, 18 Jan 2023 05:04:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=2gvCgKbn; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.47, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T4hAXAvO+pHUO7S9bMPAvNVbvyzKf0LvYzjxYgorPckC9vTnAYYF+EO4KF3ZV9CR7ZuKsaplsA2R4Xggc8v7+N8IAsdDqNuc/p/GGBtj4T5rKC8mN+zn4nLyY7ENsLkvI1Zlhv6gw9yQbOO42GiPv7ypgwDAc/1w33gfS9eJVgpt2KFP1+/1lmDXP+ZmGE5U35BkqE/kZC/YduyNNnDmchoWI5j+HXfSoWewVa7pHkU4S+Be8aCfWr3jM/+kWsoYHukAA+jr6P8+i58bqWTktTlg9z+hrLNNRzlHU+HhhUZicRDIcZJGLdVPmIEKmz2HB5xpcsKlTCwI6Up+h6Aq+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8EWabsmJhP6rzLrrZR33cJi1/98Xayyk0GQz6rbT974=; b=XCPgYW9Hqnn7Ob97mYmNEmWDA+TEV65ACpAeknOaTghfm+C1xXvksS7aPykqJQfNvHKnxEZGOI7e4hyTTTO54iLPRQS6sLYlfCKQ/ylGGZsuHU6Vrg9kd+rw2fE4YcoUz5pATLSjtkzWpBbIOfyBZS7jYTfjV0Y4lfuqYhV8XtkPQyUyp1i8mSl79eEQQ7pUjl4KXJBUs2jMGildfZTADFoIM0Ky80hL2LmMZCNtYSvnlW54gS2b+9Enejy271d8rgMeG/eGAEiQwgWtaypRwhonORK89JKApxkP3nS+eKFCXcK/x3oeix8v59Fvzu5cuk8BEsnjZpP8mw97l2bMHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8EWabsmJhP6rzLrrZR33cJi1/98Xayyk0GQz6rbT974=; b=2gvCgKbnG3ze/a7Bv4HksymO1AOUFKW77oSBTmSr/Prf71pjNp7XGngxovJGSYq6CuAIKd0fL81er3SH1G+OsiGy2cjOP5Lb3KpVTKR2zKZjDOUiYwyS1ITI0rPYLuEYTqWyGHc4jTbBBrCUWKFK3ChUPQwA9h+GtVlwIdx8vqk= Received: from CY5PR04CA0022.namprd04.prod.outlook.com (2603:10b6:930:1e::29) by PH0PR12MB7469.namprd12.prod.outlook.com (2603:10b6:510:1e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Wed, 18 Jan 2023 13:04:19 +0000 Received: from CY4PEPF0000C97A.namprd02.prod.outlook.com (2603:10b6:930:1e:cafe::ca) by CY5PR04CA0022.outlook.office365.com (2603:10b6:930:1e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.19 via Frontend Transport; Wed, 18 Jan 2023 13:04:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C97A.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6002.11 via Frontend Transport; Wed, 18 Jan 2023 13:04:19 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 18 Jan 2023 07:04:18 -0600 Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 18 Jan 2023 07:04:16 -0600 From: "Abdul Lateef Attar" To: CC: Abdul Lateef Attar , Oram Isaac W , Eric Dong , Liming Gao Subject: [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix Date: Wed, 18 Jan 2023 18:34:11 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Return-Path: AbdulLateef.Attar@amd.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C97A:EE_|PH0PR12MB7469:EE_ X-MS-Office365-Filtering-Correlation-Id: 38642164-a908-4a11-308d-08daf95482cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UoDsuhjcez/IKUNElIbg3Ef2TwAYt7HrPP9w9LG5Eil2RaIrQa2AL2wB4QmIcVYaO8c6SYEW9gUFITRBcOmybncelSU6Q+PE+SA7md9ceiilpZUBRJM22kbgp0vLeWrdVBkhXjyer0d9sozV2hCjGuFw/fBHmS0jv/O+MiusgptiP9HgKjxl+OjoVmy3LjLSsgP00j6rC9o8XMGMRXUwRaiwSMdbAhwqzXSdIC1A8Nl7CPP5hdiV+nrm4RbBUc6889GFDN7vDOLYzqQZob3Vf7IQCbRF+wunTUCYb4wIW0af70/4cYi8vOx5JLJ1E4n6jZvHt/n1pC/F9KfkZVZbX/VmpJk7qFP6xUAoKYaFGS8Gl5sZRN1WpprezFQ4TWRot+6LsJv7JjL0X+xp70Pjauvpt6JlWr6AeNle8nX/ukjf3zuoxnsOWZM/HOv18+s+ZZesUeZenTX7CNfNYoDMnT9T8b6gCqxyKP6VU5rpeFZlah2rlS1/qCwAsSVODfX7ppjj2Yhgwz8qZX+6ekWorLDnQYwAkBEnM/Utv2jh0aGp11DnN0hn9uCDtdZgUgpS1nFdX7oQU/V+4ElXonLfvsqAkPtRpEqZDE00lSCwBM2owg2QxTiYfCfxSCvPufnzcBWPN3ik4f7lRBfBfRC8xlOetXJphCB68xJgO1CmvctSDuU2H3l2qyYDVI+zkhjkKAsHOm3nRbvcQPuXiHI65wr7P59Wo9xNNVnyMyJThlIccJ9Bl90UFNLYdZOleLeg1A/DZ0IefvvaZjgTQLULkg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(46966006)(40470700004)(36840700001)(70206006)(70586007)(8676002)(6916009)(4326008)(426003)(47076005)(336012)(36756003)(83380400001)(41300700001)(2616005)(54906003)(316002)(82310400005)(36860700001)(40480700001)(2906002)(82740400003)(5660300002)(8936002)(40460700003)(81166007)(356005)(478600001)(966005)(186003)(26005)(7696005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 13:04:19.1147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38642164-a908-4a11-308d-08daf95482cc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C97A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7469 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abdul Lateef Attar PR : https://github.com/tianocore/edk2-platforms/pull/55/ V3 delta changes: Addressed below review comments from Isaac Patch 1: Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c Line 168: Don't we need to free buffer on this path? Lines 655, 1083: Please put a newline between while and the block to fre= e resources. DONE Patch 2: edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/Boar= dBootOption.c 338: Can you change to mUefiShellFileGuid and initialize it to zero? It seems misleading to me to have the default value here when it is not u= sed. I think we should also move the declarations to the beginning of the file= . DONE Cc: Oram Isaac W Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (2): BoardModulePkg: Copy device path before processing BoardModulePkg: Adds PCD to load UEFI Shell image .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++---- .../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++ .../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++---------- .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++ 4 files changed, 41 insertions(+), 20 deletions(-) --=20 2.25.1