[edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

[edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

[Ren, Suqiang]

REF: UEFI spec 2.10 Table 28.2.5
 
Change the description of RFC1323 to align with UEFI spec 2.10.

v3:
Add the NetworkPkg change for RFC1323.

v2:
Update the commit message.

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>

Suqiang Ren (2):
  MdePkg: RFC1323 definition changed to RFC7323
  NetworkPkg: RFC1323 definition changed to RFC7323

 MdePkg/Include/Protocol/Tcp6.h | 4 ++--
 NetworkPkg/TcpDxe/TcpInput.c   | 2 +-
 NetworkPkg/TcpDxe/TcpProto.h   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112909): https://edk2.groups.io/g/devel/message/112909
Mute This Topic: https://groups.io/mt/103367728/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH V3 1/2] MdePkg: RFC1323 definition changed to RFC7323

[Ren, Suqiang]

Change the description of RFC1323 to RFC7323
to align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 28.2.5

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
 MdePkg/Include/Protocol/Tcp6.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Protocol/Tcp6.h b/MdePkg/Include/Protocol/Tcp6.h
index a8787dd3af1a..d16bc06eb29b 100644
--- a/MdePkg/Include/Protocol/Tcp6.h
+++ b/MdePkg/Include/Protocol/Tcp6.h
@@ -192,12 +192,12 @@ typedef struct {
   BOOLEAN    EnableNagle;
   ///
   /// Set it to TRUE to enable TCP timestamps option as defined in
-  /// RFC1323. Set to FALSE to disable it.
+  /// RFC7323. Set to FALSE to disable it.
   ///
   BOOLEAN    EnableTimeStamp;
   ///
   /// Set it to TRUE to enable TCP window scale option as defined in
-  /// RFC1323. Set it to FALSE to disable it.
+  /// RFC7323. Set it to FALSE to disable it.
   ///
   BOOLEAN    EnableWindowScaling;
   ///
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112910): https://edk2.groups.io/g/devel/message/112910
Mute This Topic: https://groups.io/mt/103367729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH V3 2/2] NetworkPkg: RFC1323 definition changed to RFC7323

[Ren, Suqiang]

According to UEFI spec 2.10, the definition of RFC1323
has changed to RFC7323 on EFI_TCP6_OPTION. So align this
change on NetworkPkg.

REF: UEFI spec 2.10 Table 28.2.5

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
---
 NetworkPkg/TcpDxe/TcpInput.c | 2 +-
 NetworkPkg/TcpDxe/TcpProto.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/TcpDxe/TcpInput.c b/NetworkPkg/TcpDxe/TcpInput.c
index 7b329be64dfe..97633a3908be 100644
--- a/NetworkPkg/TcpDxe/TcpInput.c
+++ b/NetworkPkg/TcpDxe/TcpInput.c
@@ -1177,7 +1177,7 @@ TcpInput (
   //
   if (TCP_FLG_ON (Option.Flag, TCP_OPTION_RCVD_TS)) {
     //
-    // update TsRecent as specified in page 16 RFC1323.
+    // update TsRecent as specified in page 17 RFC7323.
     // RcvWl2 equals to the variable "LastAckSent"
     // defined there.
     //
diff --git a/NetworkPkg/TcpDxe/TcpProto.h b/NetworkPkg/TcpDxe/TcpProto.h
index 81f6a875351f..94234f969681 100644
--- a/NetworkPkg/TcpDxe/TcpProto.h
+++ b/NetworkPkg/TcpDxe/TcpProto.h
@@ -277,7 +277,7 @@ struct _TCP_CONTROL_BLOCK {
   BOOLEAN             ProbeTimerOn;            ///< If TRUE, the probe time is on.
 
   //
-  // RFC1323 defined variables, about window scale,
+  // RFC7323 defined variables, about window scale,
   // timestamp and PAWS
   //
   UINT8               SndWndScale; ///< Wndscale received from the peer.
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112911): https://edk2.groups.io/g/devel/message/112911
Mute This Topic: https://groups.io/mt/103367730/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V3 2/2] NetworkPkg: RFC1323 definition changed to RFC7323

[Saloni Kasbekar]

Reviewed-by: Saloni Kasbekar <saloni.kasbekar@intel.com>

-----Original Message-----
From: Ren, SuqiangX <suqiangx.ren@intel.com> 
Sent: Tuesday, December 26, 2023 1:02 AM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: [PATCH V3 2/2] NetworkPkg: RFC1323 definition changed to RFC7323

According to UEFI spec 2.10, the definition of RFC1323 has changed to RFC7323 on EFI_TCP6_OPTION. So align this change on NetworkPkg.

REF: UEFI spec 2.10 Table 28.2.5

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
---
 NetworkPkg/TcpDxe/TcpInput.c | 2 +-
 NetworkPkg/TcpDxe/TcpProto.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/TcpDxe/TcpInput.c b/NetworkPkg/TcpDxe/TcpInput.c index 7b329be64dfe..97633a3908be 100644
--- a/NetworkPkg/TcpDxe/TcpInput.c
+++ b/NetworkPkg/TcpDxe/TcpInput.c
@@ -1177,7 +1177,7 @@ TcpInput (
   //
   if (TCP_FLG_ON (Option.Flag, TCP_OPTION_RCVD_TS)) {
     //
-    // update TsRecent as specified in page 16 RFC1323.
+    // update TsRecent as specified in page 17 RFC7323.
     // RcvWl2 equals to the variable "LastAckSent"
     // defined there.
     //
diff --git a/NetworkPkg/TcpDxe/TcpProto.h b/NetworkPkg/TcpDxe/TcpProto.h index 81f6a875351f..94234f969681 100644
--- a/NetworkPkg/TcpDxe/TcpProto.h
+++ b/NetworkPkg/TcpDxe/TcpProto.h
@@ -277,7 +277,7 @@ struct _TCP_CONTROL_BLOCK {
   BOOLEAN             ProbeTimerOn;            ///< If TRUE, the probe time is on.
 
   //
-  // RFC1323 defined variables, about window scale,
+  // RFC7323 defined variables, about window scale,
   // timestamp and PAWS
   //
   UINT8               SndWndScale; ///< Wndscale received from the peer.
--
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112933): https://edk2.groups.io/g/devel/message/112933
Mute This Topic: https://groups.io/mt/103367730/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

[Ren, Suqiang]

Hi Liming,
	
	This patch has reviewed by Kasbekar, Saloni: https://edk2.groups.io/g/devel/message/112933

	Could you help to merge this patch?


Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang
Sent: Tuesday, December 26, 2023 5:02 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

REF: UEFI spec 2.10 Table 28.2.5
 
Change the description of RFC1323 to align with UEFI spec 2.10.

v3:
Add the NetworkPkg change for RFC1323.

v2:
Update the commit message.

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>

Suqiang Ren (2):
  MdePkg: RFC1323 definition changed to RFC7323
  NetworkPkg: RFC1323 definition changed to RFC7323

 MdePkg/Include/Protocol/Tcp6.h | 4 ++--
 NetworkPkg/TcpDxe/TcpInput.c   | 2 +-
 NetworkPkg/TcpDxe/TcpProto.h   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.26.2.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113029): https://edk2.groups.io/g/devel/message/113029
Mute This Topic: https://groups.io/mt/103367728/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

[Ren, Suqiang]

Add the Pull Request link: https://github.com/tianocore/edk2/pull/5190.

Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang
Sent: Tuesday, January 2, 2024 2:33 PM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

Hi Liming,
	
	This patch has reviewed by Kasbekar, Saloni: https://edk2.groups.io/g/devel/message/112933

	Could you help to merge this patch?


Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang
Sent: Tuesday, December 26, 2023 5:02 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

REF: UEFI spec 2.10 Table 28.2.5
 
Change the description of RFC1323 to align with UEFI spec 2.10.

v3:
Add the NetworkPkg change for RFC1323.

v2:
Update the commit message.

Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>

Suqiang Ren (2):
  MdePkg: RFC1323 definition changed to RFC7323
  NetworkPkg: RFC1323 definition changed to RFC7323

 MdePkg/Include/Protocol/Tcp6.h | 4 ++--
 NetworkPkg/TcpDxe/TcpInput.c   | 2 +-
 NetworkPkg/TcpDxe/TcpProto.h   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.26.2.windows.1













-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113083): https://edk2.groups.io/g/devel/message/113083
Mute This Topic: https://groups.io/mt/103367728/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

[Ren, Suqiang]

Hi Liming,

	Thanks for review this Pull Request: https://github.com/tianocore/edk2/pull/5190.

	Since All checks have passed. Could you please help to push it?

Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Monday, January 8, 2024 9:15 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: 回复: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

This change looks good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

I will merge it. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ren, Suqiang
> 发送时间: 2024年1月3日 20:38
> 收件人: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Kasbekar, Saloni 
> <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> 主题: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to
> RFC7323
> 
> Add the Pull Request link: https://github.com/tianocore/edk2/pull/5190.
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, 
> Suqiang
> Sent: Tuesday, January 2, 2024 2:33 PM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> Subject: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 
> to
> RFC7323
> 
> Hi Liming,
> 
> 	This patch has reviewed by Kasbekar, Saloni:
> https://edk2.groups.io/g/devel/message/112933
> 
> 	Could you help to merge this patch?
> 
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, 
> Suqiang
> Sent: Tuesday, December 26, 2023 5:02 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> Subject: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to
> RFC7323
> 
> REF: UEFI spec 2.10 Table 28.2.5
> 
> Change the description of RFC1323 to align with UEFI spec 2.10.
> 
> v3:
> Add the NetworkPkg change for RFC1323.
> 
> v2:
> Update the commit message.
> 
> Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> 
> Suqiang Ren (2):
>   MdePkg: RFC1323 definition changed to RFC7323
>   NetworkPkg: RFC1323 definition changed to RFC7323
> 
>  MdePkg/Include/Protocol/Tcp6.h | 4 ++--
>  NetworkPkg/TcpDxe/TcpInput.c   | 2 +-
>  NetworkPkg/TcpDxe/TcpProto.h   | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113437): https://edk2.groups.io/g/devel/message/113437
Mute This Topic: https://groups.io/mt/103616986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-