public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Cindy Kuo" <cindyx.kuo@intel.com>
To: devel@edk2.groups.io
Cc: Cindy Kuo <cindyx.kuo@intel.com>
Subject: [edk2-devel] [PATCH v5 0/2] SecurityPkg/OpalPasswordDxe: Update according to UEFI spec
Date: Tue, 16 Apr 2024 13:02:35 +0800	[thread overview]
Message-ID: <cover.1713241069.git.cindyx.kuo@intel.com> (raw)

For opalHii current design, it will display all NVME disks when the user enters TCG Drive Management dynamically.
Also, the related disk info form will be created along with the disks.
These actions will call get/set browser to refresh the display, which is not allowed in ACTION_FORM_OPEN callback function.

To meet UEFI 2.9 spec, a latency issue will be observed if the browser callback action changes from ACTION_FORM_OPEN to ACTION_RETRIEVE.
The NVNE disks will not be displayed when the user enters the formset at the first time. Revisit the formset can see the update.
So need to force reparsing the IFR binary when RETRIEVE.

v2:
Format code with Uncrustify.

v3:
Code refine based on comments from Dandan and Tina.

v4:
Split solution into two patches as different purpose.

v5:
Update commit message.

Cindy Kuo (2):
  SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec
  SecurityPkg/OpalPasswordDxe: Force reparsing IFR binary when RETRIEVE

 .../Tcg/Opal/OpalPassword/OpalDriver.h        |  1 +
 SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c   | 84 ++++++++++++++++---
 .../Tcg/Opal/OpalPassword/OpalHiiFormValues.h |  6 ++
 .../Tcg/Opal/OpalPassword/OpalPasswordDxe.inf |  1 +
 .../Opal/OpalPassword/OpalPasswordForm.vfr    |  8 +-
 5 files changed, 87 insertions(+), 13 deletions(-)

-- 
2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117846): https://edk2.groups.io/g/devel/message/117846
Mute This Topic: https://groups.io/mt/105551557/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-04-16  5:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  5:02 Cindy Kuo [this message]
2024-04-16  5:02 ` [edk2-devel] [PATCH v5 1/2] SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec Cindy Kuo
2024-04-16  5:02 ` [edk2-devel] [PATCH v5 2/2] SecurityPkg/OpalPasswordDxe: Force reparsing IFR binary when RETRIEVE Cindy Kuo
2024-04-16  9:21 ` [edk2-devel] [PATCH v5 0/2] SecurityPkg/OpalPasswordDxe: Update according to UEFI spec Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1713241069.git.cindyx.kuo@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox