From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 494F5AC0D98 for ; Tue, 16 Apr 2024 05:03:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MuUgqTMB3bUS60djXITc0jqVr/162tK8zcMFf5TIL+s=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1713243783; v=1; b=GGAZowfKPwY6yKsHARDeS9YNIhfFIUu0Y4i/XuiwtAzZk5rdy42H66XT2D24sbkCrSiiCrj4 ewSOQdSTfSBP+kTKQkQTN4YWDUm56obChaM1z5XeUc/yknlH2Bq4VJNwwGYNGYIgEe9RPjyJThL RjTLrje9KfrmhA2bSGo1yaWmxnN4ubOUIeyP9nSxsktiO1MZuWq4hM2uSikonxa1CaUeSvNhDKO 9CeojiE12CTclJlfTn5Un99ngdTqhNNz8u+NQ7iEtNCpw5Fqg+VqFc2VWYsEF+aRsopr73Xc5ni Wl6Oep5vJY8qpo6aA6/5r8/sPYbGB7WrOTkNDlxCHJbJQ== X-Received: by 127.0.0.2 with SMTP id Y8wIYY7687511xYDlsP9oq22; Mon, 15 Apr 2024 22:03:03 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.12704.1713243778004462760 for ; Mon, 15 Apr 2024 22:02:58 -0700 X-CSE-ConnectionGUID: xAAsU1UHSpqoRjguhDlEDg== X-CSE-MsgGUID: sXxL8hn5RkmNs8fLrjPaxg== X-IronPort-AV: E=McAfee;i="6600,9927,11045"; a="11607355" X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="11607355" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 22:02:57 -0700 X-CSE-ConnectionGUID: mWR2ed+OSNeC0jzlL8NPHw== X-CSE-MsgGUID: sNgov06FQDSKdaC+VjpMdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,205,1708416000"; d="scan'208";a="22223792" X-Received: from cindykux-mobl.gar.corp.intel.com ([10.225.33.115]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2024 22:02:56 -0700 From: "Cindy Kuo" To: devel@edk2.groups.io Cc: Cindy Kuo Subject: [edk2-devel] [PATCH v5 0/2] SecurityPkg/OpalPasswordDxe: Update according to UEFI spec Date: Tue, 16 Apr 2024 13:02:35 +0800 Message-ID: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 22:02:58 -0700 Resent-From: cindyx.kuo@intel.com Reply-To: devel@edk2.groups.io,cindyx.kuo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: W0zTpUiNm1i0Bh8U3M6CAqu1x7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=GGAZowfK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io For opalHii current design, it will display all NVME disks when the user enters TCG Drive Management dynamically. Also, the related disk info form will be created along with the disks. These actions will call get/set browser to refresh the display, which is not allowed in ACTION_FORM_OPEN callback function. To meet UEFI 2.9 spec, a latency issue will be observed if the browser callback action changes from ACTION_FORM_OPEN to ACTION_RETRIEVE. The NVNE disks will not be displayed when the user enters the formset at the first time. Revisit the formset can see the update. So need to force reparsing the IFR binary when RETRIEVE. v2: Format code with Uncrustify. v3: Code refine based on comments from Dandan and Tina. v4: Split solution into two patches as different purpose. v5: Update commit message. Cindy Kuo (2): SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec SecurityPkg/OpalPasswordDxe: Force reparsing IFR binary when RETRIEVE .../Tcg/Opal/OpalPassword/OpalDriver.h | 1 + SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 84 ++++++++++++++++--- .../Tcg/Opal/OpalPassword/OpalHiiFormValues.h | 6 ++ .../Tcg/Opal/OpalPassword/OpalPasswordDxe.inf | 1 + .../Opal/OpalPassword/OpalPasswordForm.vfr | 8 +- 5 files changed, 87 insertions(+), 13 deletions(-) -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117846): https://edk2.groups.io/g/devel/message/117846 Mute This Topic: https://groups.io/mt/105551557/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-