From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 353BBAC12EC for ; Wed, 4 Oct 2023 08:46:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=42kwmbE4YmHdu6ZNo//5T3/1E5OQ18Dz0RdSGmWPnKc=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1696409189; v=1; b=oZq91sWPJQI6S0sTg1yhvy0AKGGSIqsOMiVXpmAEAxhUicjBJMNmAR+qQaPMlNAS9dIQBTAK ZXTXPIq4xVPTn6Jwadv1y9k43AHPR3P4xqB2zqNnN6DdeYtcY+kzIxJm3X6NlBgMdV9h2g43i0p +mQGT6kBt7WoGZdoJgmGKiYQ= X-Received: by 127.0.0.2 with SMTP id E1TiYY7687511xH7nH6NoSjY; Wed, 04 Oct 2023 01:46:29 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.13808.1696409188524906014 for ; Wed, 04 Oct 2023 01:46:28 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-494-uEhA4QveM5Kmc5fvB4gDkA-1; Wed, 04 Oct 2023 04:46:14 -0400 X-MC-Unique: uEhA4QveM5Kmc5fvB4gDkA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D7F43C02542; Wed, 4 Oct 2023 08:46:14 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BC021005B96; Wed, 4 Oct 2023 08:46:13 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D400918017F0; Wed, 4 Oct 2023 10:46:11 +0200 (CEST) Date: Wed, 4 Oct 2023 10:46:11 +0200 From: "Gerd Hoffmann" To: Taylor Beebe Cc: devel@edk2.groups.io, Jian J Wang , Liming Gao Subject: Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib Message-ID: References: <20230920005752.2041-1-taylor.d.beebe@gmail.com> <20230920005752.2041-21-taylor.d.beebe@gmail.com> <2390fe7b-d994-4aed-8b45-97bf028b2cb3@gmail.com> MIME-Version: 1.0 In-Reply-To: <2390fe7b-d994-4aed-8b45-97bf028b2cb3@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zBLwCZpGdNxMmjNiQnVFFb4Wx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oZq91sWP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Sep 29, 2023 at 12:52:35PM -0700, Taylor Beebe wrote: > Sorry for the slow reply :) > > > Additional profiles which fit general use cases can be added to > SetMemoryProtectionsLib, but because this is a profile for grub > compatibility I'd say it's better suited for platform code making > MemoryProtectionConfigLib in OvmfPkg the best spot. > I'll add an additional static profile array to MemoryProtectionConfigLib > and have logic loop through both to see if a profile matches. I'll > add the GrubCompat profile you outlined to this new profile array. Sounds good to me. > I can also update ArmVirtPkg to disable execution protection > for EfiLoaderData by default until fw_cfg parsing > support is added to ArmVirtPkg. Let me know if you think > this is necessary. With MemoryProtectionConfigLib adding fw_cfg parsing support to ArmVirtPkg should be easy, so maybe just do that? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109310): https://edk2.groups.io/g/devel/message/109310 Mute This Topic: https://groups.io/mt/101469960/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-