From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Thomas Barrett <tbarrett@crusoeenergy.com>
Cc: devel@edk2.groups.io,
Anatol Belski <anbelski@linux.microsoft.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jianyong Wu <jianyong.wu@arm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Rob Bradford <rbradford@rivosinc.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv
Date: Fri, 12 Jan 2024 12:47:30 +0100 [thread overview]
Message-ID: <cvrwuyfhpptz53eziwenjhpbbdbibuxtfgzb5driteoqilvan3@zi3dmkfje2p2> (raw)
In-Reply-To: <02d4a4fa4b0fcc9d0b356ea740d1abd82caba9a4.1704998169.git.tbarrett@crusoeenergy.com>
Hi,
> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc
> index af594959a9..b522fa1059 100644
> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
> @@ -566,6 +566,8 @@
> # Point to the MdeModulePkg/Application/UiApp/UiApp.inf
> gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
> +
This is not mentioned in the commit message.
Also it should go into a separate patch (in case this is an intentional
change, which I suspect is the case).
Otherwise the series looks good to me.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113722): https://edk2.groups.io/g/devel/message/113722
Mute This Topic: https://groups.io/mt/103668740/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-12 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 19:02 [edk2-devel] [PATCH v2 0/2] Support CloudHv guests with >1TB of RAM Thomas Barrett
2024-01-11 19:02 ` [edk2-devel] [PATCH v2 1/2] OvmfPkg: Add CloudHv support to PlatformScanE820 utility function Thomas Barrett
2024-01-11 19:02 ` [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv Thomas Barrett
2024-01-12 11:47 ` Gerd Hoffmann [this message]
2024-01-12 17:56 ` Thomas Barrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cvrwuyfhpptz53eziwenjhpbbdbibuxtfgzb5driteoqilvan3@zi3dmkfje2p2 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox