From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 95EC4D81164 for ; Fri, 12 Jan 2024 11:47:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FVnYaFMGqUXCPhuFqPHpcVvSN2j8d8ch4AVhcajaUtE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705060055; v=1; b=GwUr/h13twJ13m6+xpRWWOkaVomeDiPSzOwm5nAa9t+WRSwjikU/1IMYkiUs6N9y4jKOsqgq xYiytqhCw1KpFYvkI8xPIYiE3OXKMVMoYA8T/p81z7RyCvugT+7vrytrcUdgYMOfFX+XGIc58yB L06wE2CzB2zPczgDhTnybNXM= X-Received: by 127.0.0.2 with SMTP id 4boHYY7687511xKG5vjnjOD4; Fri, 12 Jan 2024 03:47:35 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5302.1705060054523337549 for ; Fri, 12 Jan 2024 03:47:34 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-y6yqgoU_PTSzk1dqq_Syug-1; Fri, 12 Jan 2024 06:47:32 -0500 X-MC-Unique: y6yqgoU_PTSzk1dqq_Syug-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D052B84AF86; Fri, 12 Jan 2024 11:47:31 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AA7F3C25; Fri, 12 Jan 2024 11:47:31 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 611CB180079A; Fri, 12 Jan 2024 12:47:30 +0100 (CET) Date: Fri, 12 Jan 2024 12:47:30 +0100 From: "Gerd Hoffmann" To: Thomas Barrett Cc: devel@edk2.groups.io, Anatol Belski , Ard Biesheuvel , Jianyong Wu , Jiewen Yao , Laszlo Ersek , Rob Bradford Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv Message-ID: References: <02d4a4fa4b0fcc9d0b356ea740d1abd82caba9a4.1704998169.git.tbarrett@crusoeenergy.com> MIME-Version: 1.0 In-Reply-To: <02d4a4fa4b0fcc9d0b356ea740d1abd82caba9a4.1704998169.git.tbarrett@crusoeenergy.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fMexqN2QiW2bHdljjmsCLunhx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="GwUr/h13"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Hi, > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc > index af594959a9..b522fa1059 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -566,6 +566,8 @@ > # Point to the MdeModulePkg/Application/UiApp/UiApp.inf > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } > > + gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE > + This is not mentioned in the commit message. Also it should go into a separate patch (in case this is an intentional change, which I suspect is the case). Otherwise the series looks good to me. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113722): https://edk2.groups.io/g/devel/message/113722 Mute This Topic: https://groups.io/mt/103668740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-