From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@google.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb@kernel.org>,
Oliver Steffen <osteffen@redhat.com>,
Alexander Graf <graf@amazon.com>,
Oliver Smith-Denny <osde@linux.microsoft.com>,
Taylor Beebe <taylor.d.beebe@gmail.com>,
Peter Jones <pjones@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH v4] ArmVirt: Allow memory attributes protocol to be disabled
Date: Tue, 12 Dec 2023 11:07:54 +0100 [thread overview]
Message-ID: <cw4pqw72fvu4a4jm5zlcbiclg522taxxxptubcmkucpe2b7o2g@fuylonecmgkv> (raw)
In-Reply-To: <20231212083600.1889189-1-ardb@google.com>
On Tue, Dec 12, 2023 at 09:36:00AM +0100, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Shim's PE loader uses the EFI memory attributes protocol in a way that
> results in an immediate crash when invoking the loaded image, unless the
> base and size of its executable segment are both aligned to 4k.
>
> If this is not the case, it will strip the memory allocation of its
> executable permissions, but fail to add them back for the executable
> region, resulting in non-executable code. Unfortunately, the PE loader
> does not even bother invoking the protocol in this case (as it notices
> the misalignment), making it very hard for system firmware to work
> around this by attempting to infer the intent of the caller.
>
> So let's introduce a QEMU command line option to indicate that the
> protocol should not be exposed at all, and a PCD to set the default for
> this option when it is omitted.
>
> -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112384): https://edk2.groups.io/g/devel/message/112384
Mute This Topic: https://groups.io/mt/103126734/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-12 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:36 [edk2-devel] [PATCH v4] ArmVirt: Allow memory attributes protocol to be disabled Ard Biesheuvel
2023-12-12 10:07 ` Gerd Hoffmann [this message]
2023-12-12 10:42 ` Ard Biesheuvel
2023-12-12 15:22 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cw4pqw72fvu4a4jm5zlcbiclg522taxxxptubcmkucpe2b7o2g@fuylonecmgkv \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox