From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0EEDBD80084 for ; Tue, 12 Dec 2023 10:08:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nBg4RlaE1gCZanO0z/TXGpsAysHstj77vEK8mneuEB4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1702375683; v=1; b=CfZ1PL3oBJWTjn3z3a8vVFXJ5VFjr+x4fYWUOeQT4iaKca1SEADaugPuO+rDHkVAwYjCDbq8 GfC0KjtCKaumGODMRjVPW9k4+BzFr2orum59TCmm6fAtzmfDAuoItsj4e3VxsmLgLQVeCA/5w/z YvSbvuzfsSmlO+/CWwH6/BTM= X-Received: by 127.0.0.2 with SMTP id mY4cYY7687511xlQO7aiU7vN; Tue, 12 Dec 2023 02:08:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.13379.1702375683011737849 for ; Tue, 12 Dec 2023 02:08:03 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-Z1EF2vRIMMiXK9IXhEqQUw-1; Tue, 12 Dec 2023 05:07:58 -0500 X-MC-Unique: Z1EF2vRIMMiXK9IXhEqQUw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 608C5895684; Tue, 12 Dec 2023 10:07:58 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 106B5492BE6; Tue, 12 Dec 2023 10:07:58 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5E766180039F; Tue, 12 Dec 2023 11:07:54 +0100 (CET) Date: Tue, 12 Dec 2023 11:07:54 +0100 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Oliver Steffen , Alexander Graf , Oliver Smith-Denny , Taylor Beebe , Peter Jones , Leif Lindholm , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v4] ArmVirt: Allow memory attributes protocol to be disabled Message-ID: References: <20231212083600.1889189-1-ardb@google.com> MIME-Version: 1.0 In-Reply-To: <20231212083600.1889189-1-ardb@google.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wegGMc9cnnSLbuL6jTBrgPKLx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CfZ1PL3o; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Tue, Dec 12, 2023 at 09:36:00AM +0100, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > Shim's PE loader uses the EFI memory attributes protocol in a way that > results in an immediate crash when invoking the loaded image, unless the > base and size of its executable segment are both aligned to 4k. > > If this is not the case, it will strip the memory allocation of its > executable permissions, but fail to add them back for the executable > region, resulting in non-executable code. Unfortunately, the PE loader > does not even bother invoking the protocol in this case (as it notices > the misalignment), making it very hard for system firmware to work > around this by attempting to infer the intent of the caller. > > So let's introduce a QEMU command line option to indicate that the > protocol should not be exposed at all, and a PCD to set the default for > this option when it is omitted. > > -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y Tested-by: Gerd Hoffmann Reviewed-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112384): https://edk2.groups.io/g/devel/message/112384 Mute This Topic: https://groups.io/mt/103126734/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-