From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stefanb@linux.ibm.com; receiver=edk2-devel@lists.01.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66784211AF9CA for ; Fri, 25 Jan 2019 09:12:35 -0800 (PST) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0PH4akm051348 for ; Fri, 25 Jan 2019 12:12:34 -0500 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2q856qmmhd-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Jan 2019 12:12:34 -0500 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Jan 2019 17:12:32 -0000 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 25 Jan 2019 17:12:30 -0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0PHCTpg24641660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 25 Jan 2019 17:12:29 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D7F5112063; Fri, 25 Jan 2019 17:12:29 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E16D112062; Fri, 25 Jan 2019 17:12:29 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 25 Jan 2019 17:12:29 +0000 (GMT) To: lersek@redhat.com, edk2-devel@lists.01.org Cc: chao.b.zhang@intel.com, jiewen.yao@intel.com, marcandre.lureau@redhat.com References: <20190125165527.1059649-1-stefanb@linux.ibm.com> From: Stefan Berger Date: Fri, 25 Jan 2019 12:12:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190125165527.1059649-1-stefanb@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 19012517-2213-0000-0000-00000344BBC0 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010475; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000277; SDB=6.01151645; UDB=6.00600260; IPR=6.00931990; MB=3.00025287; MTD=3.00000008; XFM=3.00000015; UTC=2019-01-25 17:12:32 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19012517-2214-0000-0000-00005D1CC3DB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-25_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901250137 Subject: Re: [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 X-List-Received-Date: Fri, 25 Jan 2019 17:12:35 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-MW I have to repost this since my email has changed. On 1/25/19 11:55 AM, Stefan Berger wrote: > This patch adds the TCG2 Configuration menu to the Device Manager > menu. We can reuse all the code in the SecurityPkg and need to > only add it to the build and flash config files. > > The code is added to Ovfm by building with -DTPM2_ENABLE and > -DTPM2_CONFIG_ENABLE. > > Signed-off-by: Stefan Berger > --- > OvmfPkg/OvmfPkgIa32.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32.fdf | 4 ++++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32X64.fdf | 4 ++++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > OvmfPkg/OvmfPkgX64.fdf | 4 ++++ > 6 files changed, 21 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index aee19b75d7..68e707e7e5 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -632,6 +632,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > +!if $(TPM2_CONFIG_ENABLE) == TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > # > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index e013099136..a46598f2c3 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -295,6 +295,10 @@ INF ShellPkg/Application/Shell/Shell.inf > > INF MdeModulePkg/Logo/LogoDxe.inf > > +!if ($(TPM2_ENABLE) == TRUE) && ($(TPM2_CONFIG_ENABLE) == TRUE) > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > + > # > # Network modules > # > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 90cbd8e341..dd6c700774 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -640,6 +640,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > +!if $(TPM2_CONFIG_ENABLE) == TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > [Components.X64] > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index afaa334384..8a02b3cc79 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -296,6 +296,10 @@ INF ShellPkg/Application/Shell/Shell.inf > > INF MdeModulePkg/Logo/LogoDxe.inf > > +!if ($(TPM2_ENABLE) == TRUE) && ($(TPM2_CONFIG_ENABLE) == TRUE) > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > + > # > # Network modules > # > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 83d16eb00b..828a1d9999 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -639,6 +639,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > +!if $(TPM2_CONFIG_ENABLE) == TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > # > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index afaa334384..8a02b3cc79 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -296,6 +296,10 @@ INF ShellPkg/Application/Shell/Shell.inf > > INF MdeModulePkg/Logo/LogoDxe.inf > > +!if ($(TPM2_ENABLE) == TRUE) && ($(TPM2_CONFIG_ENABLE) == TRUE) > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > + > # > # Network modules > #