Re: [patch 5/5] MdePkg: Use VENDOR_DEVICE_PATH structure for Debug Port device path

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 10/8/2018 11:31 AM, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229
> 
> When converting DebugPort device path from text,
> current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure
> for Debug port device node.
> typedef struct {
>    EFI_DEVICE_PATH_PROTOCOL  Header;
>    EFI_GUID                  Guid;
>    UINT8                     VendorDefinedData[1];
> } VENDOR_DEFINED_MESSAGING_DEVICE_PATH;
> 
> And Debugport Device Path is a vendor-defined messaging
> device path with no data, only a GUID. So it's better to
> use VENDOR_DEVICE_PATH to create the Debug port device node.
> typedef struct {
>    EFI_DEVICE_PATH_PROTOCOL        Header;
>    EFI_GUID                        Guid;
> } VENDOR_DEVICE_PATH;
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>   MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
> index c5f3764fc0..49da8268eb 100644
> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c
> @@ -1756,16 +1756,16 @@ DevPathFromTextEmmc (
>   EFI_DEVICE_PATH_PROTOCOL *
>   DevPathFromTextDebugPort (
>     IN CHAR16 *TextDeviceNode
>     )
>   {
> -  VENDOR_DEFINED_MESSAGING_DEVICE_PATH  *Vend;
> +  VENDOR_DEVICE_PATH  *Vend;
>   
> -  Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode (
> +  Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode (
>                                                       MESSAGING_DEVICE_PATH,
>                                                       MSG_VENDOR_DP,
> -                                                    (UINT16) sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH)
> +                                                    (UINT16) sizeof (VENDOR_DEVICE_PATH)
>                                                       );
>   
>     CopyGuid (&Vend->Guid, &gEfiDebugPortProtocolGuid);
>   
>     return (EFI_DEVICE_PATH_PROTOCOL *) Vend;
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray