From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48DEF211158DA for ; Sun, 7 Oct 2018 23:53:01 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2018 23:53:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,355,1534834800"; d="scan'208";a="79580673" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2018 23:53:00 -0700 To: Dandan Bi , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao References: <20181008033158.10652-1-dandan.bi@intel.com> <20181008033158.10652-5-dandan.bi@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Mon, 8 Oct 2018 14:54:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181008033158.10652-5-dandan.bi@intel.com> Subject: Re: [patch 5/5] MdePkg: Use VENDOR_DEVICE_PATH structure for Debug Port device path X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 06:53:01 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/8/2018 11:31 AM, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229 > > When converting DebugPort device path from text, > current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure > for Debug port device node. > typedef struct { > EFI_DEVICE_PATH_PROTOCOL Header; > EFI_GUID Guid; > UINT8 VendorDefinedData[1]; > } VENDOR_DEFINED_MESSAGING_DEVICE_PATH; > > And Debugport Device Path is a vendor-defined messaging > device path with no data, only a GUID. So it's better to > use VENDOR_DEVICE_PATH to create the Debug port device node. > typedef struct { > EFI_DEVICE_PATH_PROTOCOL Header; > EFI_GUID Guid; > } VENDOR_DEVICE_PATH; > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > index c5f3764fc0..49da8268eb 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c > @@ -1756,16 +1756,16 @@ DevPathFromTextEmmc ( > EFI_DEVICE_PATH_PROTOCOL * > DevPathFromTextDebugPort ( > IN CHAR16 *TextDeviceNode > ) > { > - VENDOR_DEFINED_MESSAGING_DEVICE_PATH *Vend; > + VENDOR_DEVICE_PATH *Vend; > > - Vend = (VENDOR_DEFINED_MESSAGING_DEVICE_PATH *) CreateDeviceNode ( > + Vend = (VENDOR_DEVICE_PATH *) CreateDeviceNode ( > MESSAGING_DEVICE_PATH, > MSG_VENDOR_DP, > - (UINT16) sizeof (VENDOR_DEFINED_MESSAGING_DEVICE_PATH) > + (UINT16) sizeof (VENDOR_DEVICE_PATH) > ); > > CopyGuid (&Vend->Guid, &gEfiDebugPortProtocolGuid); > > return (EFI_DEVICE_PATH_PROTOCOL *) Vend; > Reviewed-by: Ruiyu Ni -- Thanks, Ray