Re: [PATCH] ArmPlatformPkg/NorFlashDxe: eliminate void pointer arithmetic

[Laszlo Ersek <lersek@redhat.com>]

On 10/24/16 15:01, Ard Biesheuvel wrote:
> While most compilers happily allow arithmetic on void pointer,
> the RVCT compiler does not, and throws the following warning for
> NorFlashDxe:
> 
>   ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c(894,48) :
>   error  #1254-D: arithmetic on pointer to void or function type
> 
> Since the expression in question involves a cast from UINTN to VOID*,
> simply add some parentheses to eliminate this warning.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c
> index ca61ac5e1983..1098d9501cc7 100644
> --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c
> +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c
> @@ -891,7 +891,7 @@ NorFlashRead (
>    SEND_NOR_COMMAND (Instance->DeviceBaseAddress, 0, P30_CMD_READ_ARRAY);
>  
>    // Readout the data
> -  AlignedCopyMem (Buffer, (VOID *)StartAddress + Offset, BufferSizeInBytes);
> +  AlignedCopyMem (Buffer, (VOID *)(StartAddress + Offset), BufferSizeInBytes);
>  
>    return EFI_SUCCESS;
>  }
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>