From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4353.1622105109751604619 for ; Thu, 27 May 2021 01:45:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KgYPETdP; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622105108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUtHL0sHFL/QVj08dQFCNXAMEoXxClO5VWuERIHjYGE=; b=KgYPETdP1xnoQO3EJDIAk/BR4GnWbxBNaRDEtOJauWBjdQRsOH4iAQDXrJUC9d0SHqpBB2 thwDoHdFBhn+k9RXxp0yBKEgbcieDOG5/HoNu/xvrs0KnSWTteYyNmL9LfDH+IWaKmjeWC kIBwDlD8yrSEsdWluraoZQHXc4kf5zo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-Z5uDQypfMRWGn9ZfDYnZqg-1; Thu, 27 May 2021 04:45:07 -0400 X-MC-Unique: Z5uDQypfMRWGn9ZfDYnZqg-1 Received: by mail-wr1-f69.google.com with SMTP id v5-20020adf9e450000b029010e708f05b3so1478475wre.6 for ; Thu, 27 May 2021 01:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QUtHL0sHFL/QVj08dQFCNXAMEoXxClO5VWuERIHjYGE=; b=IuLJfpqNKiwgD06Pxs9IOSTzbrB1p6CNv0ITWwrVKlTHJnfJDFKljkZ5xapzEalPxp ceyj89KUZi9DVHpTIQZHXg85D99C2fNRCe7K/OJs8muatgb23D4yR3blsSOqi78/XtBZ yS5QQ2XZqF+/doLbjBBS9CmZeDH6fTQ/vdXA32lOpHP4Ab61HrywavAJxV7g+G+x3Wyu H5sQZe5aLZkUmBizv5fDvVZ+ABJQK6wLQsbZHk1SnrGN8WedSx7e+vib2H78cEdWColo HC7sS0JUvCsNeJgbAw3b1yp3M3/fuSzQPV0ZnmegSTHn616H61UXcPh8cvUMbo2FC6+a PuVg== X-Gm-Message-State: AOAM531vdYvO7OJYyWguHSQSJhNt8XIAhk3N7VOvJ771UlMpboOGLast tj+RkKn1NX7jW02I6A6xpOHKZ8vXiLXoiLRSVUhjxYwn3JZKVhyrSHOko0a4qZa75yctoG+5irQ A1Zv3wlGe+SQCgQ== X-Received: by 2002:a1c:f60f:: with SMTP id w15mr7288547wmc.5.1622105106098; Thu, 27 May 2021 01:45:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxocW7+q6LtO5mtU/d/5rhPUo+shI0vLffO+LGysTyhDpv/0kIhputDYHm5OQWo2W42Cz/Zgw== X-Received: by 2002:a1c:f60f:: with SMTP id w15mr7288536wmc.5.1622105105980; Thu, 27 May 2021 01:45:05 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id e8sm2032980wrt.30.2021.05.27.01.45.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:45:05 -0700 (PDT) Subject: Re: [PATCH 37/43] OvmfPkg/SmbiosPlatformDxe: return EFI_NOT_FOUND if there is no SMBIOS data To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-38-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:45:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-38-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > According to the function-top comment, SmbiosTablePublishEntry() is > supposed to return an error code if no SMBIOS data is found, from either > GetXenSmbiosTables() or GetQemuSmbiosTables(). Currently the function > returns EFI_SUCCESS in this case however (propagated from > gBS->LocateProtocol()). Make the return code match the documentation. > > (This issue is not too important, but it gets in the way of splitting the > entry point function next.) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daude