From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.15476.1638980131546857093 for ; Wed, 08 Dec 2021 08:15:31 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=XC1UWlC6; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id AF10E20B7179; Wed, 8 Dec 2021 08:15:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AF10E20B7179 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1638980131; bh=+48KSnlOVb1NNnFcYLW4oubE+bqVFeG9ACwuPvi9a8k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=XC1UWlC6Ie7mvIDXqgX5Po5+k7Rt017w7cduQT+MKGCwYyc1d4YdI1zWC9TZzITDh QA/cWbFbLMKovE7Qcew5CS7bBZ5Ths22KGdLrAX3SvnGVhgFXOEgiedqtv2nWx7ugq pqr2VJ7TiNXXmATI4fIBGUr8VNUDnk3YY4170yJ4= Message-ID: Date: Wed, 8 Dec 2021 11:15:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard" To: Brijesh Singh , "Kinney, Michael D" , "devel@edk2.groups.io" References: <8bb9a4b2-2e04-62df-f688-9b6357091d21@amd.com> <18d2cc3b-9b31-3d8a-29b4-a0f888fd9afc@amd.com> From: "Michael Kubacki" In-Reply-To: <18d2cc3b-9b31-3d8a-29b4-a0f888fd9afc@amd.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable That's correct. I recommend using the "stuart_update -c=20 .pytool/CISettings.py" command so the proper version will automatically=20 get brought down into your local workspace. Thanks, Michael On 12/8/2021 11:10 AM, Brijesh Singh wrote: >=20 >=20 > On 12/8/21 8:39 AM, Brijesh Singh wrote: > ... >=20 >>> OvmfPkg Example: >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0 git ls-files OvmfPkg/*.c OvmfPkg/*.h :!BaseT= ools/* |=20 >>> .pytool\Plugin\UncrustifyCheck\mu-uncrustify-release_extdep\Windows-x= 86\uncrustify.exe=20 >>> -c .pytool\Plugin\UncrustifyCheck\uncrustify.cfg -F - --replace=20 >>> --no-backup --if-changed >>> >>> >> >> Thanks for the detail, I just did a pull and now I see the uncrustify=20 >> cfg files. I followed your above command on my Ubuntu desktop and=20 >> getting the below unknown symbol, is this a known issue ? >> >> >> brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ git ls-files=20 >> OvmfPkg/Sec/AmdSev.c | uncrustify -c=20 >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F - --replace=20 >> --no-backup --if-changed >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:73: unknown symbol=20 >> 'nl_func_call_args_multi_line_ignore_closures' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:79: unknown symbol=20 >> 'indent_func_call_edk2_style' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:120: unknown symbol=20 >> 'sp_do_brace_open' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:134: unknown symbol=20 >> 'sp_before_vardef_square' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:178: unknown symbol=20 >> 'sp_brace_close_while' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:184: unknown symbol=20 >> 'sp_before_square_asm_block' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:205: unknown symbol=20 >> 'sp_while_paren_open' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:229: unknown symbol=20 >> 'indent_func_def_param_paren_pos_threshold' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:270: unknown symbol=20 >> 'align_edk2_style' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:323: unknown symbol=20 >> 'cmt_align_doxygen_javadoc_tags' >> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:406: unknown symbol=20 >> 'nl_before_whole_file_ifdef' >> Parsing: OvmfPkg/Sec/AmdSev.c as language C >> brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ >> brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ uncrustify --version >> Uncrustify-0.69.0_f >> >> I did submitted PR after above uncurstify run but the CI still didn't=20 >> like it. Do we need to have specific version of uncrustify ? >> >=20 > Reading through the "Add Uncrustify formatting overview" email it seems= =20 > we need to use a edk2 forked=C2=A0 version of uncrustify [1]. With this= now I=20 > dont get any error. >=20 > [1]=20 > https://dev.azure.com/projectmu/Uncrustify/_packaging?_a=3Dpackage&feed= =3Dmu_uncrustify&package=3Dmu-uncrustify-release&version=3D73.0.3&protoco= lType=3DNuGet=20 >=20 >=20 >=20 >=20 > thanks