From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stefanb@linux.ibm.com; receiver=edk2-devel@lists.01.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D491211BA456 for ; Fri, 25 Jan 2019 13:25:44 -0800 (PST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0PLP3qS044112 for ; Fri, 25 Jan 2019 16:25:44 -0500 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0b-001b2d01.pphosted.com with ESMTP id 2q87yy5njm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Jan 2019 16:25:43 -0500 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Jan 2019 21:25:43 -0000 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 25 Jan 2019 21:25:39 -0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0PLPc8H24641592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 25 Jan 2019 21:25:38 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C661112062; Fri, 25 Jan 2019 21:25:38 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48515112061; Fri, 25 Jan 2019 21:25:38 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 25 Jan 2019 21:25:38 +0000 (GMT) To: Laszlo Ersek , edk2-devel@lists.01.org Cc: chao.b.zhang@intel.com, jiewen.yao@intel.com, marcandre.lureau@redhat.com, "Jordan Justen (Intel address)" , Ard Biesheuvel , Anthony Perard , Julien Grall References: <20190125171247.1059745-1-stefanb@linux.ibm.com> <12640142-e533-68b6-1207-1b30cd9d7158@redhat.com> From: Stefan Berger Date: Fri, 25 Jan 2019 16:25:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <12640142-e533-68b6-1207-1b30cd9d7158@redhat.com> X-TM-AS-GCONF: 00 x-cbid: 19012521-0064-0000-0000-0000039D1E92 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010477; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000277; SDB=6.01151730; UDB=6.00600310; IPR=6.00932074; MB=3.00025290; MTD=3.00000008; XFM=3.00000015; UTC=2019-01-25 21:25:41 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19012521-0065-0000-0000-00003C2CAAEE Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-25_14:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901250163 Subject: Re: [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 X-List-Received-Date: Fri, 25 Jan 2019 21:25:45 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-MW On 1/25/19 2:30 PM, Laszlo Ersek wrote: > Hi, > > (1) when posting a patch, please CC all people marked with "M" for the > subject package in Maintainers.txt. And, if in doubt, please CC the "R" > people too. > > Adding the others now. > > (2) In [a] [b], you mentioned a need to repost, due to your email > address having changed. However, that posting, and this posting, seem to > come from the same email address, and to use the same S-o-b: "Stefan > Berger ". I re-subscribed to the ml. Old address was stefanb@linux.vnet.ibm.com. > > [a] http://mid.mail-archive.com/d0222c94-4578-74bd-94ad-90d10911b534@linux.ibm.com > [b] https://lists.01.org/pipermail/edk2-devel/2019-January/035701.html > > On 01/25/19 18:12, Stefan Berger wrote: >> This patch adds the TCG2 Configuration menu to the Device Manager >> menu. > OK. > >> We can reuse all the code in the SecurityPkg and need to >> only add it to the build and flash config files. > (3) I disagree with this formulation. > > Instead, we can apparently include the *sample* Tcg2ConfigDxe from > SecurityPkg as-is, without obvious adverse effects. I consider this an I will reuse some of this formulation. > experimental feature that's being enabled (not by default) in order to > support further R&D. The Tcg2ConfigDxe has not been trimmed / modified > for OVMF / QEMU specifics (unlike Tcg2ConfigPei in commit 6cf1880fb5b6). > That's why we are gating Tcg2ConfigDxe with TPM2_CONFIG_ENABLE, and not > enabling it simply as part of TPM2_ENABLE. > >> The code is added to Ovfm by building with -DTPM2_ENABLE and >> -DTPM2_CONFIG_ENABLE. > (4) Typo, s/Ovfm/OVMF/. "OVMF" stands for Open Virtual Machine Firmware. :-) > >> Signed-off-by: Stefan Berger > (5) Before your S-o-b, please add: > > """ > Contributed-under: TianoCore Contribution Agreement 1.1 > """ > > after reviewing "Contributions.txt" in the project root dir. Done. > >> --- >> OvmfPkg/OvmfPkgIa32.dsc | 3 +++ >> OvmfPkg/OvmfPkgIa32.fdf | 4 ++++ >> OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ >> OvmfPkg/OvmfPkgIa32X64.fdf | 4 ++++ >> OvmfPkg/OvmfPkgX64.dsc | 3 +++ >> OvmfPkg/OvmfPkgX64.fdf | 4 ++++ >> 6 files changed, 21 insertions(+) > (6) In all three DSC files, please DEFINE TPM2_CONFIG_ENABLE = FALSE as > well, just below TPM2_ENABLE. Done. > >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index aee19b75d7..68e707e7e5 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -632,6 +632,9 @@ >> NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf >> NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf >> } >> +!if $(TPM2_CONFIG_ENABLE) == TRUE >> + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf >> +!endif >> !endif >> >> # > This looks good. > >> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf >> index e013099136..a46598f2c3 100644 >> --- a/OvmfPkg/OvmfPkgIa32.fdf >> +++ b/OvmfPkg/OvmfPkgIa32.fdf >> @@ -295,6 +295,10 @@ INF ShellPkg/Application/Shell/Shell.inf >> >> INF MdeModulePkg/Logo/LogoDxe.inf >> >> +!if ($(TPM2_ENABLE) == TRUE) && ($(TPM2_CONFIG_ENABLE) == TRUE) >> +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf >> +!endif >> + > (7) In this file, we already have > > """ > !if $(TPM2_ENABLE) == TRUE > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > !endif > """ > > elsewhere. Can you please nest the addition in that scope? Done. > > Thanks, > Laszlo >