From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.6.1587139193025162964 for ; Fri, 17 Apr 2020 08:59:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 183BFC14; Fri, 17 Apr 2020 08:59:52 -0700 (PDT) Received: from [10.37.9.4] (unknown [10.37.9.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A47AD3F73D; Fri, 17 Apr 2020 08:59:50 -0700 (PDT) Subject: Re: [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix To: Laszlo Ersek , edk2-devel-groups-io Cc: Anthony Perard , Jordan Justen , Julien Grall , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran References: <20200417153751.7110-1-lersek@redhat.com> From: "Ard Biesheuvel" Message-ID: Date: Fri, 17 Apr 2020 17:59:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200417153751.7110-1-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/17/20 5:37 PM, Laszlo Ersek wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2675 > Repo: https://pagure.io/lersek/edk2.git > Branch: rsl_cleanup >=20 > Rebecca's >=20 > [PATCH 02/13] OvmfPkg: support powering off bhyve guests >=20 > at >=20 > https://edk2.groups.io/g/devel/message/57450 > http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6= .1586991816.git.rebecca@bsdio.com >=20 > made me realize OvmfPkg/ResetSystemLib should be refreshed. This will > let us add a simple bhyve-specific instance (later), and also allows us > to fix a long time dormant bug (now). >=20 > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Rebecca Cran >=20 > Thanks, > Laszlo >=20 > Laszlo Ersek (6): > OvmfPkg/ResetSystemLib: wrap long lines > OvmfPkg/ResetSystemLib: clean up library dependencies > OvmfPkg/ResetSystemLib: improve coding style in ResetSystem() > OvmfPkg/ResetSystemLib: factor out ResetShutdown() > OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib > OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib instance >=20 For the series, Reviewed-by: Ard Biesheuvel One nit: putting a diff block inside the commit log [6/6] doesn't help=20 legibility a lot, and the issue of not being able to access memory that=20 is not mapped for runtime is so basic that it doesn't require that level=20 of detail to describe a reproducer and the Linux kernel log output when=20 the issue is triggered. > OvmfPkg/OvmfPkgIa32.dsc = | 8 +- > OvmfPkg/OvmfPkgIa32X64.dsc = | 8 +- > OvmfPkg/OvmfPkgX64.dsc = | 8 +- > OvmfPkg/OvmfXen.dsc = | 6 +- > OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D> BaseResetSyst= emLib.inf} | 12 ++- > OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf = | 43 ++++++++++ > OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c = | 51 ++++++++++++ > OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c = | 62 +++++++++++++++ > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c = | 84 +++++--------------- > 9 files changed, 209 insertions(+), 73 deletions(-) > rename OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D> BaseRe= setSystemLib.inf} (65%) > create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.i= nf > create mode 100644 OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c > create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c >=20