From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=EMPqPa/9; spf=pass (domain: gmx.de, ip: 212.227.17.22, mailfrom: xypron.glpk@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by groups.io with SMTP; Mon, 02 Sep 2019 03:14:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1567419273; bh=0ZiIDLbNMC7D/DrLfOWGl2/VsTukFFNe4M2P6XP07EM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=EMPqPa/9/77x1KCgb8/vfEBM4MoDy+GAteRQSCzCfxXxDOvOBMSHTwuaaLaYfGpnf YcKYrmxzVNQQkj0dv60Hbh3Et914TXcoCkk5krvAtX7HBSVnWQFF7Un9bmeC7VKhxN wfZIcgGcvJFw6m9dVkwGj7nMdC4budcd5TYy2Usw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.48] ([84.118.159.3]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3se8-1iDHzd3FVw-00zp7H; Mon, 02 Sep 2019 12:14:33 +0200 Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak To: "Carsey, Jaben" , "devel@edk2.groups.io" , "Gao, Zhichao" Cc: "Ni, Ray" , Leif Lindholm , "Gao, Liming" , Stephano Cetola References: <20190510032419.14540-1-xypron.glpk@gmx.de> From: "Heinrich Schuchardt" Message-ID: Date: Mon, 2 Sep 2019 12:14:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:5s8k2ybmsuDRhpRDea/cv8eH5MkeKJdoawJgzXtQXBFm68G1M1l Li+WX3XyUmgUXrFGIXLjB4glno9AANWMS6md0rigtzbF3J5pisTZC2YWfiVV5HTqmlOtQRF ht5nCVJ5qaL891DdD4ItDH7u6aU0/YtpvrCUBaW+uVnsYVfxI9KqKtHkcJwxMP+t8p9sh3o pmoMA7Xt+rA+WfNy632hQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+/NpH7dS72A=:6gCO/wXTfD7d5LXAOY4s3D 9uD1rFrf3zFPugpqD5JGQZ6potx6O7+tIAFgSqsiIFnNRXe3LGFhCtaYdt3DeXoL3owq2oQSe 58JYRnIfL4x9dheJ46gANrNTZuAszmadzaNTjzuX4XkdQ8ZlArgT57zPbEoYywyNFbvR488W8 UU0tEh/b6Q4Vi/3cLwMbkttqu1csKhCwAh6S/9WPmYvAaR0XRCbOUWk02nbHWSng8n0jEv1Th ElBB659eNB1Y7bFQB6f2Fv+73o5AEBWM4SsijHI696B/IgoClSFx92wA/B+Q5T38wJwiMMCuk bw+uqA8IoO3N2mPUbLGUJYfNw7f32ukpwP9dGZ0Zy1B9lI4u5/2XyBtqW/C3YovdrKUmGWqg7 tBfFk5nxyzL2CU+QOp1kQ6Ey/E2WA/sPz0T4nv4O+6fbvJMeJmTETQG5CvVgDa3zWqoSD4CBR W46uNFghrOqATQX2af6ZtDqH6joYkkB1xJLAzHSMFwYYm9A0jA4hgAon/LaSulAg07BQMIazN LnKDfN7cWpIOYBa448AndkxzB57O6DDLm9JfhLQ3jeAU4fMXC0SWlxDF02kEip5JyNpbfvF92 SHzrsFAVDOXU5UpnWJoGkuiHj9aOaofKk2lFPW1IKuSI2Gz4MkrIgTOHIb4yy6WFxI8947HMV 46VBmEi6iQsRUMWbDQ/v+UqgcfjiYO/Vs0uvFacE4ib2ossy3Xn2SMf9yW+aqT5u0UJse1oLg 7ilWzWVUVmV4I5UGFgUoj82ccmYrkw24tyc3gFyUo23iXvUB7U9sza7gU546Q1UzKitQ0K4RJ XhM18HdcuEvlaqcLbXsfco4hR48qQOZJloWoL2feVBAXR8tClbLJIrDj/I8JqG9Indja+gg27 V3qyOqYszT2ag0YLCxW+OW/Ys0jC2FcUlcRUmxm6y74/oamTadepwaLeFC35fi0oCJATIp2ZJ kGjq4/+btd/OZjaCuTKhvLVCi6shiQgU1A4hfHmOxt2BjD8pWtgiN+Qj2GL3wEHffGBn4H9kS 7/wWHj1iUc5SSnm1+TbsfcUn3m9gawqYWwRmb5hIR7tPUvRswcyNV7JuyxLrvn5VflCpcvZl6 YIG28KBdftaNg4ByFnJBS0mzV3AYxkCPNDF/Op1XuyVYXQnXxFxRAEf6bCQ9GrGev9RLPLcIw lD/Nk7uZSCL7L79aBjoKxM1ryikSepTaAVnySzChqTfxYRbw== Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/10/19 4:32 PM, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > Code change looks good visually. Somehow this patch https://edk2.groups.io/g/devel/message/40395 was never merged. Who is the maintainer for the ShellPkg? Best regards Heinrich