From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.496.1580319042774635327 for ; Wed, 29 Jan 2020 09:30:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ATgPhU+6; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580319041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNx5hP9jpFNV+RYcFCYDz1+6omg0eZJFkm3RxFS5gTU=; b=ATgPhU+6heQ+kSYNkVVdkgv1/9qQ/8v8uBIAHvR7Ysrx/fYfdDtEQGxEYmrsXPFC1vMORJ aabPExABRnkUn3VBxOybM7mcnQr6nEDspasSNXiCVnSq/xyeq/FLCN4ibkJpL6s8v+NIwY 0ISTBd8mfYj3B/6jpL9+0xuwab1TcEg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-0XH5yy8wOB2wbsvs_-a9tw-1; Wed, 29 Jan 2020 12:30:25 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC606800D4C; Wed, 29 Jan 2020 17:30:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE16060BF3; Wed, 29 Jan 2020 17:30:18 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/IndustryStandard: define macros for QEMU's CPU hotplug registers To: devel@edk2.groups.io, philmd@redhat.com Cc: Ard Biesheuvel , Igor Mammedov , Jordan Justen References: <20191022221554.14963-1-lersek@redhat.com> <20191022221554.14963-3-lersek@redhat.com> <4cbe775a-ca0f-2c49-302a-50965360e508@redhat.com> <78640e55-de54-2c02-98d8-2fbdc7922a73@redhat.com> <7eb17416-c10f-95ae-9e2e-2b9220180644@redhat.com> <2fbe95f0-1c8c-5342-691d-d76b0486f06d@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 29 Jan 2020 18:30:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2fbe95f0-1c8c-5342-691d-d76b0486f06d@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 0XH5yy8wOB2wbsvs_-a9tw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On 01/29/20 15:43, Philippe Mathieu-Daud=E9 wrote: > Hi Laszlo, >=20 > On 1/24/20 12:40 PM, Laszlo Ersek wrote: >> On 10/24/19 17:12, Philippe Mathieu-Daud=E9 wrote: >>> This patch is fine then. >>> >>> Since the QEMU spec is RFC and not merged, I'm worried it might >>> change. I'd rather review this patch again once the QEMU spec >>> update is accepted/merged. >> >> Igor's QEMU work is now upstream: 3e08b2b9cb64..3a61c8db9d25 >> >> Can you please re-check this patch? No changes should be necessary. >> >> In particular, >> >> - QEMU commit e6d0c3ce6895 ("acpi: cpuhp: introduce 'Command data 2' >> field", 2020-01-22) covers the definition of QEMU_CPUHP_R_CMD_DATA2, in >> this patch, >> >> - QEMU commit ae340aa3d256 ("acpi: cpuhp: spec: add typical usecases", >> 2020-01-22), section "detect and enable modern CPU hotplug interface", >> matches the QEMU_CPUHP_R_CMD_DATA2 usage in the next patch of this >> series. >=20 > Re-checked correctly. Thanks for waiting/tracking it get merged. >=20 > My Reviewed-by stands. >=20 >>> Reviewed-by: Philippe Mathieu-Daude Thank you. I've also retested it now; it works. Merged via ; commit range c8b8157e126a..83357313dd67. Thanks! Laszlo