From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.8449.1615381949184348623
 for <devel@edk2.groups.io>;
 Wed, 10 Mar 2021 05:12:29 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=APLnVgue;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1615381948;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vEOAMSjYpNar9Bz787jJkaspQMysJh3N3C06vOIQHL0=;
	b=APLnVgue0Phg158iAntZ5JHRdUiJEwA8sxwKN5DnJGlDpUDq9trBlCn6AKVO7ea6YIcDOW
	6vTs5o0z/XQ2fcNdpglwJ1qJPT+DyrqnH+gVAfPUotRNjaD17cku8k5Jk6VrjaAEii23HY
	Dxen2Dg//VINECvJq6HwdFcGAuaY/ys=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-36-ELxEr90JMbijXGV85GKfZw-1; Wed, 10 Mar 2021 08:12:26 -0500
X-MC-Unique: ELxEr90JMbijXGV85GKfZw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 641231005582;
	Wed, 10 Mar 2021 13:12:25 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-138.ams2.redhat.com [10.36.115.138])
	by smtp.corp.redhat.com (Postfix) with ESMTP id F3A9A60DAE;
	Wed, 10 Mar 2021 13:12:23 +0000 (UTC)
Subject: Re: [PATCH 1/2] Maintainers.txt: Add reviewers for the OvmfPkg TDX-related files
To: Min Xu <min.m.xu@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Leif Lindholm <leif@nuviainc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>
References: <20210310025532.2108-1-min.m.xu@intel.com>
 <20210310025532.2108-2-min.m.xu@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <d11c1ed8-646d-1e3d-5cf7-92458b7e4baf@redhat.com>
Date: Wed, 10 Mar 2021 14:12:22 +0100
MIME-Version: 1.0
In-Reply-To: <20210310025532.2108-2-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 03/10/21 03:55, Min Xu wrote:
> Register reviewers for the TDX-related files in OvmfPkg.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
>  Maintainers.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e38497123857..7d9fe89d6d28 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -465,6 +465,10 @@ F: OvmfPkg/PlatformPei/AmdSev.c
>  R: Tom Lendacky <thomas.lendacky@amd.com>
>  R: Brijesh Singh <brijesh.singh@amd.com>
>  
> +OvmfPkg: TDX-related modules
> +R: Jiewen Yao <jiewen.yao@intel.com>
> +R: Min Xu <min.m.xu@intel.com>
> +
>  OvmfPkg: TCG- and TPM2-related modules
>  F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
>  F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> 

I'm OK with the patch content, however the placement of the new section
is not right. We strive to keep the section headers alphabetically
ordered. Here's an excerpt (pre-patch):

OvmfPkg: SEV-related modules
OvmfPkg: TCG- and TPM2-related modules
OvmfPkg: Xen-related modules

I think that the new section belongs between TCG and Xen.

Thanks
Laszlo